From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 415ADECE58B for ; Thu, 3 Oct 2019 16:38:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16D58222C4 for ; Thu, 3 Oct 2019 16:38:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IkRwuZhN"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="RU1Pbl0Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16D58222C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b5PdFl4fqBYDhHXCfFOEJ2CqnN0gZi1F+8nXjTSp29A=; b=IkRwuZhNUYNO1uBBK290bVxYK 98UJPdzb2Fb7m2/UCw/s+3c1Xlpcv+6BBFe4B7hq8rCfHv6Kjw320Qq6o4l9um1JNsTAOJZvcE/tQ cpjaP2lF6WesneZuCGXU+jti39/hRdsbsWO7xX2UYhcbqPzG/3LFW4/4HrIlm/vpaaxRjUhrERohm XkXVcEfdbqcVvHd1+Jqa6c1oNGE+EHqYqy7ljzzZslZOE+XpHVESjfeujhD7bp4bU/HSLiXk/+stZ 7syZm0pnzGxPVi1y9GODuZvk2CqPXl+SE4AXZXc55vQDil3XFLtrYFifX8oXNMpnqoYjE9geBGvo0 +6yEindTg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG476-0004sy-L4; Thu, 03 Oct 2019 16:38:00 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iG473-0004s4-Cv for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2019 16:37:58 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F7E42133F; Thu, 3 Oct 2019 16:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570120677; bh=Kz986FZTTTDnNoVFmPcbG3VSLFyOjROZGgK9lBe2Pvk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RU1Pbl0ZjKw/1JN9jK3kOl8Gt37hSfFL8r4BHJyMFMaNV5TdY0RjRuXt5fyWsjfSm TWLgffGocARG6lVnth2w7sDfIeAJqzmwO7O4dFuLrHXiiYoV6mAKI1MHxrU1RuskAH BWvGu+5/VL24P+qlhweRM7JwbwAGYgw8TeGJvKYU= Date: Thu, 3 Oct 2019 18:37:54 +0200 From: Maxime Ripard To: Chen-Yu Tsai Subject: Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock Message-ID: <20191003163754.26ciq2ljcbuuvcrx@gilmour> References: <20191003154842.248763-1-mripard@kernel.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_093757_481420_4D63E70E X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Rob Herring , Sakari Ailus , Mauro Carvalho Chehab , Frank Rowand , linux-arm-kernel , Linux Media Mailing List Content-Type: multipart/mixed; boundary="===============1836012791721673345==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1836012791721673345== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="azkpqs6gqd4oy5tf" Content-Disposition: inline --azkpqs6gqd4oy5tf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > It turns out that what was thought to be the module clock was actually the > > clock meant to be used by the sensor, and isn't playing any role with the > > CSI controller itself. Let's drop that clock from our binding. > > > > Fixes: c5e8f4ccd775 ("media: dt-bindings: media: Add Allwinner A10 CSI binding") > > Reported-by: Chen-Yu Tsai > > Signed-off-by: Maxime Ripard > > --- > > .../devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > index 5dd1cf490cd9..d3e423fcb6c2 100644 > > --- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > +++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml > > @@ -27,14 +27,12 @@ properties: > > clocks: > > items: > > - description: The CSI interface clock > > - - description: The CSI module clock > > - description: The CSI ISP clock > > - description: The CSI DRAM clock > > > > clock-names: > > items: > > - const: bus > > - - const: mod > > - const: isp > > - const: ram > > > > @@ -89,9 +87,8 @@ examples: > > compatible = "allwinner,sun7i-a20-csi0"; > > reg = <0x01c09000 0x1000>; > > interrupts = ; > > - clocks = <&ccu CLK_AHB_CSI0>, <&ccu CLK_CSI0>, > > - <&ccu CLK_CSI_SCLK>, <&ccu CLK_DRAM_CSI0>; > > - clock-names = "bus", "mod", "isp", "ram"; > > + clocks = <&ccu CLK_AHB_CSI0>, <&ccu CLK_CSI_SCLK>, <&ccu CLK_DRAM_CSI0>; > > + clock-names = "bus", "isp", "ram"; > > I believe what we thought was the ISP clock is actually the module clock > for the whole CSI subsystem. So we should still use the module clock entry, > and remove the ISP entry. I'm really not sure it is. CSI1 on the A20 (possibly the A10 as well, I haven't checked), and the one on the A13 don't have any ISP embedded in the CSI controller. It makes some difference, because according to the BSP, you can see that the ISP clock is taken for CSI0: https://github.com/linux-sunxi/linux-sunxi/blob/sunxi-3.4/drivers/media/video/sun4i_csi/csi0/sun4i_drv_csi.c#L389 While for CSI1, that block is commented out, and the ISP clock never used: https://github.com/linux-sunxi/linux-sunxi/blob/sunxi-3.4/drivers/media/video/sun4i_csi/csi1/sun4i_drv_csi.c#L396 So I really believe that the ISP clock is here to feed the ISP block within the CSI controller if there's any. But it's far from always the case, as opposed to a module clock for the whole CSI controller that would be here in both cases. Maxime --azkpqs6gqd4oy5tf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXZYj4gAKCRDj7w1vZxhR xTlAAP9TTXfs33G7+Twffb5d00sxowv1ZbiAYMTsgJB/x9wG9AEAmLeDsEVVNJ/5 tHNBJCNnb+iJ6/SiGoXKqrh+GwYd4wQ= =RhyU -----END PGP SIGNATURE----- --azkpqs6gqd4oy5tf-- --===============1836012791721673345== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1836012791721673345==--