Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Soeren Moch <smoch@web.de>
To: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org, Soeren Moch <smoch@web.de>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] arm64: dts: rockchip: fix RockPro64 sdhci settings
Date: Thu,  3 Oct 2019 23:50:35 +0200
Message-ID: <20191003215036.15023-2-smoch@web.de> (raw)
In-Reply-To: <20191003215036.15023-1-smoch@web.de>

The RockPro64 schematics [1], [2] show that the rk3399 EMMC_STRB pin is
connected to the RESET pin instead of the DATA_STROBE pin of the eMMC module.
So the data strobe cannot be used for its intended purpose on this board,
and so the HS400 eMMC mode is not functional. Limit the controller to HS200.

[1] http://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf
[2] http://files.pine64.org/doc/rock64/PINE64_eMMC_Module_20170719.pdf

Fixes: e4f3fb490967 ("arm64: dts: rockchip: add initial dts support for Rockpro64")
Signed-off-by: Soeren Moch <smoch@web.de>
---
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: linux-rockchip@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
index 845eb070b5b0..2e44dae4865a 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
@@ -636,8 +636,7 @@

 &sdhci {
 	bus-width = <8>;
-	mmc-hs400-1_8v;
-	mmc-hs400-enhanced-strobe;
+	mmc-hs200-1_8v;
 	non-removable;
 	status = "okay";
 };
--
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03 21:50 [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings Soeren Moch
2019-10-03 21:50 ` Soeren Moch [this message]
2019-10-04 20:05   ` [PATCH 2/3] arm64: dts: rockchip: fix RockPro64 sdhci settings Heiko Stuebner
2019-10-03 21:50 ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings Soeren Moch
2019-10-04  0:01   ` Robin Murphy
2019-10-04  0:53     ` Soeren Moch
2019-10-04  2:13       ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Shawn Lin
2019-10-04  3:39         ` Soeren Moch
2019-10-04 14:20           ` Robin Murphy
2019-10-04 14:42             ` Jonas Karlman
2019-10-04 15:33             ` Shawn Lin
2019-10-04 17:24               ` Sören Moch
2019-10-04 20:15                 ` Soeren Moch
2019-10-04 20:18                   ` Heiko Stuebner
2019-10-04 20:39                     ` Sören Moch
2019-10-11  8:22                 ` Jonas Karlman
2019-10-11 11:40                   ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings Soeren Moch
2019-10-11 13:00                     ` Robin Murphy
2019-10-11 14:16                       ` Soeren Moch
2019-10-12  4:09                         ` Shawn Lin
2019-10-12 12:45                           ` Soeren Moch
2019-10-04 16:39             ` [PATCH 3/3] arm64: dts: rockchip: fix RockPro64 sdmmc settings【请注意,邮件由linux-rockchip-bounces+shawn.lin=rock-chips.com@lists.infradead.org代发】 Soeren Moch
2019-10-04 20:04 ` [PATCH 1/3] arm64: dts: rockchip: fix RockPro64 vdd-log regulator settings Heiko Stuebner

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003215036.15023-2-smoch@web.de \
    --to=smoch@web.de \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git