From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78A5BC47404 for ; Fri, 4 Oct 2019 10:23:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44944207FF for ; Fri, 4 Oct 2019 10:23:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LaJ0/w46" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44944207FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nxZYrohONh7wY15a839ziWhidwZgFwcaNASKsScv0Bk=; b=LaJ0/w46Z5URH9 yDohVoKDWlI6L7ctGsVVyzx+oUUyn50cj8K45JQbjPA76mpiVNxH1QMuxlOWkkMbcc+nGbGVbsmeB RWqXbzwBFsRtmn2b2RNbChGZqdhyHZ1LLjfLkkrtbOXdlBCLEJp1in/1erIzffNC38cno2AIXcQM3 squv4PbBJ9MmdL2JwceQjtD8GeOIPPe0biL1NF25TDz8BrlTx6LQKR1f//XM/Ltbd2PJ3iyUsuye4 ATloD8b2oW7HfObXLuyQxiaainKFlmhnFGF+ACu9v2ND4P+NNbO/JkkyDr/St7wnOFnSsFkaA3VO5 wXJa5owl/wDwgRbNxzAQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGKjm-00026Y-Vr; Fri, 04 Oct 2019 10:23:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGKjk-00025z-0t for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 10:23:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CB82D15A1; Fri, 4 Oct 2019 03:22:58 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF9BE3F706; Fri, 4 Oct 2019 03:22:57 -0700 (PDT) Date: Fri, 4 Oct 2019 11:22:55 +0100 From: Mark Rutland To: James Morse Subject: Re: [PATCH 3/8] arm64: Add prototypes for functions called by entry.S Message-ID: <20191004102255.GC34756@lakrids.cambridge.arm.com> References: <20191003171642.135652-1-james.morse@arm.com> <20191003171642.135652-4-james.morse@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191003171642.135652-4-james.morse@arm.com> User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191004_032300_109786_7BAFC428 X-CRM114-Status: GOOD ( 13.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , Julien Thierry , linux-arm-kernel@lists.infradead.org, Masami Hiramatsu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 03, 2019 at 06:16:37PM +0100, James Morse wrote: > Functions that are only called by assembly don't always have a > C header file prototype. > > Add the prototypes before moving the assembly callers to C. > > Signed-off-by: James Morse > --- > arch/arm64/include/asm/exception.h | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/arch/arm64/include/asm/exception.h b/arch/arm64/include/asm/exception.h > index b0b3ba56e919..8bb3fe2d71a8 100644 > --- a/arch/arm64/include/asm/exception.h > +++ b/arch/arm64/include/asm/exception.h > @@ -31,5 +31,26 @@ static inline u32 disr_to_esr(u64 disr) > } > > asmlinkage void enter_from_user_mode(void); > +asmlinkage void do_mem_abort(unsigned long addr, unsigned int esr, > + struct pt_regs *regs); > +asmlinkage void do_sp_pc_abort(unsigned long addr, unsigned int esr, > + struct pt_regs *regs); > +asmlinkage void do_undefinstr(struct pt_regs *regs); > +asmlinkage void bad_mode(struct pt_regs *regs, int reason, unsigned int esr); > +asmlinkage void do_debug_exception(unsigned long addr, unsigned int esr, > + struct pt_regs *regs); Trivial: potentially s/addr/addr_if_watchpoint/, since that got renamed recently. > +asmlinkage void do_fpsimd_acc(unsigned int esr, struct pt_regs *regs); > +asmlinkage void do_sve_acc(unsigned int esr, struct pt_regs *regs); > +asmlinkage void do_fpsimd_exc(unsigned int esr, struct pt_regs *regs); > +asmlinkage void do_sysinstr(unsigned int esr, struct pt_regs *regs); > +asmlinkage void do_sp_pc_abort(unsigned long addr, unsigned int esr, > + struct pt_regs *regs); > +asmlinkage void bad_el0_sync(struct pt_regs *regs, int reason, > + unsigned int esr); > +asmlinkage void do_cp15instr(unsigned int esr, struct pt_regs *regs); > +asmlinkage void el0_svc_handler(struct pt_regs *regs); > +asmlinkage void el0_svc_compat_handler(struct pt_regs *regs); > +asmlinkage void do_el0_ia_bp_hardening(unsigned long addr, unsigned int esr, > + struct pt_regs *regs); Otherwise those all look right, so either way: Acked-by: Mark Rutland Mark. > > #endif /* __ASM_EXCEPTION_H */ > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel