From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F58DC4360C for ; Fri, 4 Oct 2019 16:34:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68D6A222BE for ; Fri, 4 Oct 2019 16:34:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="o3evnWHg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68D6A222BE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x74H7firZz+BVbPSV3VB9B81+7GcktEPZGLeBnBttEU=; b=o3evnWHgVNIqSC iS0P3T4GQtjQEQkTCySXHNc+8CzlkgEyv4ziQyHLWn+c6wbAlxJxX3lKUxSrubMIsMShpFBlbBgzJ A/mdV9Aqv9wPpXnzukn/SqW2Rr4i0zDZbrRRHoG9XfsKULDQVPQ4NThsFUXcq2W0kZSxnQSYZxTsS uUy75HAAIh1xYyXIlPJDI6sKfl6QSVuLRtOJ7ICoaiZj3lmiyMWYncpgLXpWZGpKFX7S83/Rxu+IV bcgDmM1ZHNRmymRiq6jpGEvHgV+4BSzYCNIVO8sh2XQdLBQW/yVhCQ06PiMpz08NU0uYIQYSRzOrt ERyyIQH2jdEImSv8YmfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGQXE-0000zP-PQ; Fri, 04 Oct 2019 16:34:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGQXA-0000yu-Q0 for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 16:34:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 112161597; Fri, 4 Oct 2019 09:34:24 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28CA43F68E; Fri, 4 Oct 2019 09:34:23 -0700 (PDT) Date: Fri, 4 Oct 2019 17:34:21 +0100 From: Mark Rutland To: James Morse Subject: Re: [PATCH 2/8] arm64: remove __exception annotations Message-ID: <20191004163420.GL34756@lakrids.cambridge.arm.com> References: <20191003171642.135652-1-james.morse@arm.com> <20191003171642.135652-3-james.morse@arm.com> <20191004101717.GB34756@lakrids.cambridge.arm.com> <20191004231033.537af57806db6316b18cb0b5@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191004_093424_887478_4E6C9838 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Julien Thierry , Will Deacon , Masami Hiramatsu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 04, 2019 at 05:08:11PM +0100, James Morse wrote: > On 04/10/2019 15:10, Masami Hiramatsu wrote: > > On Fri, 4 Oct 2019 11:17:17 +0100 > > Mark Rutland wrote: > >> On Thu, Oct 03, 2019 at 06:16:36PM +0100, James Morse wrote: > >>> Since commit 732674980139 ("arm64: unwind: reference pt_regs via embedded > >>> stack frame") arm64 has has not used the __exception annotation to dump > >>> the pt_regs during stack tracing. in_exception_text() has no callers. > >>> > >>> This annotation is only used to blacklist kprobes, it means the same as > >>> __kprobes. > >>> > >>> Section annotations like this require the functions to be grouped > >>> together between the start/end markers, and placed according to > >>> the linker script. For kprobes we also have NOKPROBE_SYMBOL() which > >>> logs the symbol address in a section that kprobes parses and > >>> blacklists at boot. > >>> > >>> Using NOKPROBE_SYMBOL() instead lets kprobes publish the list of > >>> blacklisted symbols, and saves us from having an arm64 specific > >>> spelling of __kprobes. > > >>> diff --git a/arch/arm64/include/asm/exception.h b/arch/arm64/include/asm/exception.h > >>> index a17393ff6677..b0b3ba56e919 100644 > >>> --- a/arch/arm64/include/asm/exception.h > >>> +++ b/arch/arm64/include/asm/exception.h > >> > >> [...] > >> > >>> -asmlinkage void __exception do_debug_exception(unsigned long addr_if_watchpoint, > >>> - unsigned int esr, > >>> - struct pt_regs *regs) > >>> +asmlinkage void do_debug_exception(unsigned long addr_if_watchpoint, > >>> + unsigned int esr, struct pt_regs *regs) > >>> { > >>> const struct fault_info *inf = esr_to_debug_fault_info(esr); > >>> unsigned long pc = instruction_pointer(regs); > >> > >> I assume you meant to add NOKPROBE_SYMBOL(do_debug_exception) here. > >> > >> Assuming so, and with that fixed up: > >> > >> Acked-by: Mark Rutland > > > > Good catch, if so, this looks good to me too. > > I should have noted it in the commit message, but the NOKPROBE_SYMBOL(do_debug_exception) > is already there! Added by commit 2dd0e8d2d2a15 ("arm64: Kprobes with single stepping > support"). > > (kprobing the debug handler is so bad, we blacklist it twice!) Ah; neat! > I'll fix the commit message. > > > > with that fixed up: > > > > Acked-by: Masami Hiramatsu > > I assume you're both happy for me to apply these tags. Certainly! Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel