From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: mark.rutland@arm.com, marex@denx.de,
Marco Felsch <m.felsch@pengutronix.de>,
devicetree@vger.kernel.org, andrew.smirnov@gmail.com,
shawnguo@kernel.org, s.hauer@pengutronix.de, angus@akkea.ca,
linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
manivannan.sadhasivam@linaro.org,
Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file
Date: Mon, 7 Oct 2019 00:38:48 +0200 [thread overview]
Message-ID: <20191006223848.GE19803@latitude> (raw)
In-Reply-To: <20190930194332.12246-3-andreas@kemnade.info>
[-- Attachment #1.1: Type: text/plain, Size: 1396 bytes --]
Thanks for CCing me on this patchset. Nice to see more e-book reader
related work!
A few comments and questions below.
On Mon, Sep 30, 2019 at 09:43:31PM +0200, Andreas Kemnade wrote:
> The Netronix board E60K02 can be found some several Ebook-Readers,
> at least the Kobo Clara HD and the Tolino Shine 3. The board
> is equipped with different SoCs requiring different pinmuxes.
Do I understand it correctly that i.MX6SL and i.MX6SLL are pin-
compatible so we can use the same pin numbers and GPIO handles in the
DT?
> + leds {
> + compatible = "gpio-leds";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_led>;
> +
> + GLED {
What does "GLED" mean? It's not obvious to me.
What user-visible purpose does this LED have, or where is it on the
board?
> + gpios = <&gpio5 7 GPIO_ACTIVE_LOW>;
> + linux,default-trigger = "timer";
> + };
> + };
> +
> + memory {
> + reg = <0x80000000 0x80000000>;
2 GiB of memory?
> + /* Core3_3V3 */
What are these labels (Core3_3V3, Core4_1V2, etc.)?
> + dcdc2_reg: DCDC2 {
> + regulator-name = "DCDC2";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-state-mem {
> + regulator-on-in-suspend;
> + regulator-suspend-max-microvolt = <3300000>;
> + regulator-suspend-min-microvolt = <3300000>;
> + };
> + };
Thanks,
Jonathan Neuschäfer
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-06 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 19:43 [PATCH v2 0/3] dts: ARM: add Kobo Clara HD eBook reader Andreas Kemnade
2019-09-30 19:43 ` [PATCH v2 1/3] dt-bindings: arm: fsl: add compatible string for Kobo Clara HD Andreas Kemnade
2019-09-30 19:43 ` [PATCH v2 2/3] ARM: dts: add Netronix E60K02 board common file Andreas Kemnade
2019-10-06 22:38 ` Jonathan Neuschäfer [this message]
2019-10-07 5:48 ` Andreas Kemnade
2019-10-10 5:31 ` Andreas Kemnade
2019-10-10 10:50 ` Jonathan Neuschäfer
2019-09-30 19:43 ` [PATCH v2 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006223848.GE19803@latitude \
--to=j.neuschaefer@gmx.net \
--cc=andreas@kemnade.info \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=letux-kernel@openphoenux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=manivannan.sadhasivam@linaro.org \
--cc=marex@denx.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).