Re: [PATCH v15 13/14] gpio: max3191x: Utilize the for_each_set_clump8 macro

From: kbuild test robot <lkp@intel.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>
Cc: linux-arch@vger.kernel.org, Mathias Duckeck <m.duckeck@kunbus.de>,
	preid@electromag.com.au,
	William Breathitt Gray <vilhelm.gray@gmail.com>,
	linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com,
	linus.walleij@linaro.org, linux-pm@vger.kernel.org,
	linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org,
	morten.tiljeset@prevas.dk, sean.nyekjaer@prevas.dk,
	bgolaszewski@baylibre.com, lukas@wunner.de, geert@linux-m68k.org,
	kbuild-all@01.org, akpm@linux-foundation.org,
	andriy.shevchenko@linux.intel.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v15 13/14] gpio: max3191x: Utilize the for_each_set_clump8 macro
Date: Mon, 7 Oct 2019 03:26:08 +0800	[thread overview]
Message-ID: <201910070330.0CoLVziH%lkp@intel.com> (raw)
In-Reply-To: <f07b6bb5619ea1365cc58266254a7b5be65a9082.1570299719.git.vilhelm.gray@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]

Hi William,

I love your patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-for_each_set_clump8-macro/20191006-032112
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-randconfig-s0-201940 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-max3191x.c: In function 'max3191x_get_multiple':
>> drivers/gpio/gpio-max3191x.c:258:31: error: 'offset' undeclared (first use in this function)
      bitmap_set_value8(bits, in, offset);
                                  ^~~~~~
   drivers/gpio/gpio-max3191x.c:258:31: note: each undeclared identifier is reported only once for each function it appears in

vim +/offset +258 drivers/gpio/gpio-max3191x.c

   231	
   232	static int max3191x_get_multiple(struct gpio_chip *gpio, unsigned long *mask,
   233					 unsigned long *bits)
   234	{
   235		struct max3191x_chip *max3191x = gpiochip_get_data(gpio);
   236		const unsigned int wordlen = max3191x_wordlen(max3191x);
   237		int ret;
   238		unsigned long bit;
   239		unsigned long gpio_mask;
   240		unsigned long in;
   241	
   242		mutex_lock(&max3191x->lock);
   243		ret = max3191x_readout_locked(max3191x);
   244		if (ret)
   245			goto out_unlock;
   246	
   247		bitmap_zero(bits, gpio->ngpio);
   248		for_each_set_clump8(bit, gpio_mask, mask, gpio->ngpio) {
   249			unsigned int chipnum = bit / MAX3191X_NGPIO;
   250	
   251			if (max3191x_chip_is_faulting(max3191x, chipnum)) {
   252				ret = -EIO;
   253				goto out_unlock;
   254			}
   255	
   256			in = ((u8 *)max3191x->xfer.rx_buf)[chipnum * wordlen];
   257			in &= gpio_mask;
 > 258			bitmap_set_value8(bits, in, offset);
   259		}
   260	
   261	out_unlock:
   262		mutex_unlock(&max3191x->lock);
   263		return ret;
   264	}
   265	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30399 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel