From: Alain Volmat <alain.volmat@st.com>
To: Pierre Yves MORDRET <pierre-yves.mordret@st.com>
Cc: alexandre.torgue@st.com, wsa@the-dreams.de,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
fabrice.gasnier@st.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1
Date: Mon, 7 Oct 2019 14:01:20 +0200 [thread overview]
Message-ID: <20191007120120.GB12773@gnbcxd0016.gnb.st.com> (raw)
In-Reply-To: <a5093a73-ba62-ae37-10dc-3434c9da40f7@st.com>
Hi Pierre-Yves,
thanks for the comments.
On Mon, Oct 07, 2019 at 09:59:22AM +0200, Pierre Yves MORDRET wrote:
> Hi Alain
>
> Fixes tag is missing in your patch.
> [ i.e ==> Fixes: aeb068c57214 ("i2c: i2c-stm32f7: add driver") ]
Okay, will push a v2 for that.
>
> Nonetheless patch only consists in removing a comment character ?
Yes, the comment currently starts in a way of a kernel-doc description
(https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#function-documentation) leading the compiler to produce the warning since there is no
function prototype after the comment.
Regards,
Alain
>
> Thanks
>
> On 10/4/19 4:55 PM, Alain Volmat wrote:
> > Remove the following warning:
> >
> > drivers/i2c/busses/i2c-stm32f7.c:315:
> > warning: cannot understand function prototype:
> > 'struct stm32f7_i2c_spec i2c_specs[] =
> >
> > Signed-off-by: Alain Volmat <alain.volmat@st.com>
> > ---
> > drivers/i2c/busses/i2c-stm32f7.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c
> > index d36cf08..7aa4a47 100644
> > --- a/drivers/i2c/busses/i2c-stm32f7.c
> > +++ b/drivers/i2c/busses/i2c-stm32f7.c
> > @@ -305,7 +305,7 @@ struct stm32f7_i2c_dev {
> > struct regmap *regmap;
> > };
> >
> > -/**
> > +/*
> > * All these values are coming from I2C Specification, Version 6.0, 4th of
> > * April 2014.
> > *
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-07 12:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:55 [PATCH] i2c: i2c-stm32f7: remove warning when compiling with W=1 Alain Volmat
2019-10-07 7:59 ` Pierre Yves MORDRET
2019-10-07 12:01 ` Alain Volmat [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007120120.GB12773@gnbcxd0016.gnb.st.com \
--to=alain.volmat@st.com \
--cc=alexandre.torgue@st.com \
--cc=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pierre-yves.mordret@st.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).