From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E81ECE58C for ; Mon, 7 Oct 2019 14:01:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 252B120867 for ; Mon, 7 Oct 2019 14:01:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EdhiP/03"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="1dC/oO7K" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 252B120867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dFfD35S1xKD7yB5GkPQnHASC30IOLFwNMJxhgav59CY=; b=EdhiP/03N2UexG kyDuDZsZXPCbxbCzQVJ38ObtsLOjn8/FxGEdJ43ta9rMcWC88ODroWX5lVInpPg+lfKM5E+nzmSKV BoRdtgpz5SVi2Nl0QjEprDep2/UgIW3IydL1YSEii+HKpftEuR6pMZiy6fIIBJPcaNXN+PW1cqULn M2BYjlZGs9fErVTqeUyYvjZSrVWWdVXJ5lXvqFJUgMqjVh5EntQ14yp0xnVRHkEA4x71CL/J1ngyG R/jWAk04TlW6ss/zLlIfLDKr63zQQrJANC41xcfA3hchbm+J6DqTgELGh/XN7bgcelujNP/3AUCtr eaULO3ibyvNU7wwMEJtg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHTZS-0008DY-BH; Mon, 07 Oct 2019 14:01:06 +0000 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHTZP-0008BF-6S for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 14:01:04 +0000 Received: by mail-ed1-x543.google.com with SMTP id v8so12573800eds.2 for ; Mon, 07 Oct 2019 07:01:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rKL1w3iXknpln9Ux2lFi8nURmFThC0ACAB38j7xMJOw=; b=1dC/oO7KYUhQk3Cp+gPvQQFfNUhXo7xBP7fOg6lJXEJoNi4xqoFx/+Z/eteEJO7TfS beXRbX34FM5TGrxRC9UtlPyVu0dSHSWxoZtuR+BBMIz3ysIcWEMjUC0trYfvncn0/S1K bedaHLGes2jPFyGX3hZIeFJI6nEWOI1RFwcmLQ/j5X/1FPSdYeaocVmbj1FV4QMO0Ct3 gzIXMAqry05u2l85X3+0Gg6QDGEktesNKTlT1AuPCVLEt0ZvIsj2v9MyWo4Idq82kDyc ct/NK1YDtzPjx53EMdfO2f0gZjT1d4J5zb0WVTYkaD/x8lXnVmFKIb86ehHVrjIfm46m og+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rKL1w3iXknpln9Ux2lFi8nURmFThC0ACAB38j7xMJOw=; b=mu+gd8uY7jCTtRHTl/+RhFkK/8R2s5IR4sNR5G7gbHdrM+EOl17wzqHpAq70Siw4iE kQcSm8Ti28giCwNjoMJxmu1AsS+vXZWtwbJofKEWxJ9AzJpV1enQEJy0xQOszgHdNl7V W5RV7Z/D2AI3bs/ow60UJI8/AOTh3rLe6z45yoSSWGJrj2fWZ8sa18oxFqwfWJXM2yGF f8UqyR91N1+3uaVIaH1AG5C611Wnl3IczNEUN/DWIL9gCI4SMFprM+mrraGiQFJIL75/ +i51c9IJ5K5FDMukzkXzV3BymCcdzdrcCcJJ7xjbLmhorhksIpg8PhSh8SQQ/4izb/Ka blbg== X-Gm-Message-State: APjAAAU7KOiBqS1l7yGyhEvkQ6ycxHUrZaqnCl4QZ1TgIHG4wYVPVRH5 5i0yQjR9nLpsGHrfFKoKidVgCg== X-Google-Smtp-Source: APXvYqxuYtPtzk9H5R4kXUotDVtZLwRxmHkom44kwHAzQPnIVU9Dw79/zIRyaunZCbGIUeO/BsAK1g== X-Received: by 2002:a17:906:4d08:: with SMTP id r8mr10168700eju.283.1570456860258; Mon, 07 Oct 2019 07:01:00 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r18sm3382249edl.6.2019.10.07.07.00.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 07:00:59 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id BDCFF100287; Mon, 7 Oct 2019 17:00:58 +0300 (+03) Date: Mon, 7 Oct 2019 17:00:58 +0300 From: "Kirill A. Shutemov" To: Ingo Molnar Subject: Re: [PATCH V4 2/2] mm/pgtable/debug: Add test validating architecture page table helpers Message-ID: <20191007140058.um5g44rvxyzyiref@box> References: <1570427124-21887-1-git-send-email-anshuman.khandual@arm.com> <1570427124-21887-3-git-send-email-anshuman.khandual@arm.com> <20191007130617.GB56546@gmail.com> <20191007132607.4q537nauwfn5thol@box> <20191007135158.GA36360@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191007135158.GA36360@gmail.com> User-Agent: NeoMutt/20180716 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_070103_239787_6973318C X-CRM114-Status: GOOD ( 24.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , James Hogan , Tetsuo Handa , Heiko Carstens , Michal Hocko , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, Thomas Gleixner , linux-s390@vger.kernel.org, Michael Ellerman , x86@kernel.org, Russell King - ARM Linux , Matthew Wilcox , Steven Price , Jason Gunthorpe , Gerald Schaefer , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kees Cook , Anshuman Khandual , Masahiro Yamada , Mark Brown , Dan Williams , Vlastimil Babka , Christophe Leroy , Sri Krishna chowdary , Ard Biesheuvel , Greg Kroah-Hartman , Dave Hansen , linux-mips@vger.kernel.org, Ralf Baechle , linux-kernel@vger.kernel.org, Paul Burton , Mike Rapoport , Vineet Gupta , Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 07, 2019 at 03:51:58PM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > On Mon, Oct 07, 2019 at 03:06:17PM +0200, Ingo Molnar wrote: > > > > > > * Anshuman Khandual wrote: > > > > > > > This adds a test module which will validate architecture page table helpers > > > > and accessors regarding compliance with generic MM semantics expectations. > > > > This will help various architectures in validating changes to the existing > > > > page table helpers or addition of new ones. > > > > > > > > Test page table and memory pages creating it's entries at various level are > > > > all allocated from system memory with required alignments. If memory pages > > > > with required size and alignment could not be allocated, then all depending > > > > individual tests are skipped. > > > > > > > diff --git a/arch/x86/include/asm/pgtable_64_types.h b/arch/x86/include/asm/pgtable_64_types.h > > > > index 52e5f5f2240d..b882792a3999 100644 > > > > --- a/arch/x86/include/asm/pgtable_64_types.h > > > > +++ b/arch/x86/include/asm/pgtable_64_types.h > > > > @@ -40,6 +40,8 @@ static inline bool pgtable_l5_enabled(void) > > > > #define pgtable_l5_enabled() 0 > > > > #endif /* CONFIG_X86_5LEVEL */ > > > > > > > > +#define mm_p4d_folded(mm) (!pgtable_l5_enabled()) > > > > + > > > > extern unsigned int pgdir_shift; > > > > extern unsigned int ptrs_per_p4d; > > > > > > Any deep reason this has to be a macro instead of proper C? > > > > It's a way to override the generic mm_p4d_folded(). It can be rewritten > > as inline function + define. Something like: > > > > #define mm_p4d_folded mm_p4d_folded > > static inline bool mm_p4d_folded(struct mm_struct *mm) > > { > > return !pgtable_l5_enabled(); > > } > > > > But I don't see much reason to be more verbose here than needed. > > C type checking? Documentation? Yeah, I know it's just a one-liner, but > the principle of the death by a thousand cuts applies here. Okay, if you think it worth it. Anshuman, could you fix it up for the next submission? > BTW., any reason this must be in the low level pgtable_64_types.h type > header, instead of one of the API level header files? I defined it next pgtable_l5_enabled(). What is more appropriate place to you? pgtable_64.h? Yeah, it makes sense. -- Kirill A. Shutemov _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel