From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABE77C4360C for ; Thu, 10 Oct 2019 13:18:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8103D206B6 for ; Thu, 10 Oct 2019 13:18:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qTXh/UcV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8103D206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IK/qFZwle7T8mebeB2UhhO8nY4xS3F/c7vv+ok21aeQ=; b=qTXh/UcV4fzD+J obmPM1mp5GaQtPTnn41aT3uk7Mjv921aALgNDcvyNhv2FyhV+u82ATzZ4Xx6xd6uPsgiLVaIKSz4k NjgvW+Qxs+SpSQaA8sz5P0iHuONVhHFMoIzWFQ5M7bT8llVmMQufKe3uHTYrawhi7gLtRS7GjgF3x eLwLTss5iPCekVZt6iZREazt/sU9BvfmdebvbVwkKE9gMnQqGNkwpO02rYtj/JxDIqYxnf6cHc0xa tOeD0a1uaUlbwE/p+elAAXsiWtorM49TaGA2IAQEsIy6y1g9W2lrr/lX57TkMwTub7L+AlRBh3stX UPKCHU5AWxc8PE68P5qg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIYLC-0001Cd-U4; Thu, 10 Oct 2019 13:18:50 +0000 Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iIYLA-0001C1-G6 for linux-arm-kernel@lists.infradead.org; Thu, 10 Oct 2019 13:18:49 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Oct 2019 06:18:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,280,1566889200"; d="scan'208";a="277774911" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001.jf.intel.com with ESMTP; 10 Oct 2019 06:18:43 -0700 Received: from andy by smile with local (Exim 4.92.2) (envelope-from ) id 1iIYL4-0006iA-Ey; Thu, 10 Oct 2019 16:18:42 +0300 Date: Thu, 10 Oct 2019 16:18:42 +0300 From: Andy Shevchenko To: Andrew Morton Subject: Re: [PATCH v18 01/14] bitops: Introduce the for_each_set_clump8 macro Message-ID: <20191010131842.GT32742@smile.fi.intel.com> References: <893c3b4f03266c9496137cc98ac2b1bd27f92c73.1570641097.git.vilhelm.gray@gmail.com> <20191009141855.310f1fa8bde58df0df27b8f0@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191009141855.310f1fa8bde58df0df27b8f0@linux-foundation.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_061848_544414_58702797 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Arnd Bergmann , linux-gpio@vger.kernel.org, yamada.masahiro@socionext.com, linus.walleij@linaro.org, linux-pm@vger.kernel.org, linux@rasmusvillemoes.dk, William Breathitt Gray , linux-kernel@vger.kernel.org, bgolaszewski@baylibre.com, lukas@wunner.de, geert@linux-m68k.org, preid@electromag.com.au, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Oct 09, 2019 at 02:18:55PM -0700, Andrew Morton wrote: > On Wed, 9 Oct 2019 13:14:37 -0400 William Breathitt Gray wrote: > > > This macro iterates for each 8-bit group of bits (clump) with set bits, > > within a bitmap memory region. For each iteration, "start" is set to the > > bit offset of the found clump, while the respective clump value is > > stored to the location pointed by "clump". Additionally, the > > bitmap_get_value8 and bitmap_set_value8 functions are introduced to > > respectively get and set an 8-bit value in a bitmap memory region. > > > > ... > > > > +#define for_each_set_clump8(start, clump, bits, size) \ > > + for ((start) = find_first_clump8(&(clump), (bits), (size)); \ > > + (start) < (size); \ > > + (start) = find_next_clump8(&(clump), (bits), (size), (start) + 8)) > > + > > It wouldn't hurt to give this some documentation. In kerneldoc form, I > guess. Good idea! William, I have just tested your series with a complex hardware setup, everything works to me. I think I may give Tested-by: Andy Shevchenko for this patch as well. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel