From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
kernel@pengutronix.de, Matt Helsley <mhelsley@vmware.com>
Subject: Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling
Date: Thu, 10 Oct 2019 22:14:00 +0200 [thread overview]
Message-ID: <20191010201400.k4tcsbx2cqe5wjqs@pengutronix.de> (raw)
In-Reply-To: <20191010122321.7329329f@gandalf.local.home>
On Thu, Oct 10, 2019 at 12:23:21PM -0400, Steven Rostedt wrote:
> On Wed, 9 Oct 2019 17:22:18 +0200
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
>
> > > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> > > index 3796eb37fb12..6dbec46b7703 100644
> > > --- a/scripts/recordmcount.h
> > > +++ b/scripts/recordmcount.h
> > > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *const relhdr,
> > > mcountsym = get_mcountsym(sym0, relp, str0);
> > >
> > > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
> > > - if (make_nop) {
> > > + if (make_nop)
> > > ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
> > > - if (ret < 0)
> > > - return -1;
> > > - }
> >
> > Yes, this patch fixes building for me.
>
> May I add to my patch:
>
> Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Yeah, sure.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-10 20:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1564596289.git.mhelsley@vmware.com>
[not found] ` <8ba8633d4afe444931f363c8d924bf9565b89a86.1564596289.git.mhelsley@vmware.com>
2019-10-09 10:46 ` [PATCH v4 4/8] recordmcount: Rewrite error/success handling Uwe Kleine-König
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-10 16:23 ` Steven Rostedt
2019-10-10 20:14 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010201400.k4tcsbx2cqe5wjqs@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).