From: Sebastian Reichel <sre@kernel.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: alexandre.belloni@bootlin.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] power: reset: at91-poweroff: lookup for proper PMC DT node
Date: Mon, 14 Oct 2019 08:59:13 +0200 [thread overview]
Message-ID: <20191014065913.k244l6gdgfiu4jsk@earth.universe> (raw)
In-Reply-To: <1569493537-7612-1-git-send-email-claudiu.beznea@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 1643 bytes --]
Hi,
On Thu, Sep 26, 2019 at 01:25:37PM +0300, Claudiu Beznea wrote:
> Driver has been enabled also for SAM9X60. At the moment the patch which did
> this has been sent to mainline the PMC for SAM9X60 wasn't integrated.
> SAM9X60 has a new PMC compatible (see commit 01e2113de9a5
> ("clk: at91: add sam9x60 pmc driver")). Do to this we have to
> look for proper PMC compatible here, in SHDWC driver.
>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
Thanks, queued.
-- Sebastian
> drivers/power/reset/at91-sama5d2_shdwc.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c
> index e341cc5c0ea6..1c18f465a245 100644
> --- a/drivers/power/reset/at91-sama5d2_shdwc.c
> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c
> @@ -269,6 +269,12 @@ static const struct of_device_id at91_shdwc_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, at91_shdwc_of_match);
>
> +static const struct of_device_id at91_pmc_ids[] = {
> + { .compatible = "atmel,sama5d2-pmc" },
> + { .compatible = "microchip,sam9x60-pmc" },
> + { /* Sentinel. */ }
> +};
> +
> static int __init at91_shdwc_probe(struct platform_device *pdev)
> {
> struct resource *res;
> @@ -313,7 +319,7 @@ static int __init at91_shdwc_probe(struct platform_device *pdev)
>
> at91_shdwc_dt_configure(pdev);
>
> - np = of_find_compatible_node(NULL, NULL, "atmel,sama5d2-pmc");
> + np = of_find_matching_node(NULL, at91_pmc_ids);
> if (!np) {
> ret = -ENODEV;
> goto clk_disable;
> --
> 2.7.4
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-14 21:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 10:25 [PATCH] power: reset: at91-poweroff: lookup for proper PMC DT node Claudiu Beznea
2019-10-14 6:59 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014065913.k244l6gdgfiu4jsk@earth.universe \
--to=sre@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).