From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9703AC4CECE for ; Tue, 15 Oct 2019 00:47:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66D8F2089C for ; Tue, 15 Oct 2019 00:47:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lkQQe5E0"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="L9NGZ3K9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66D8F2089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vnx9If6XY8iAkHF9ty82yepYABhn6jIsbFDaw6UYf3k=; b=lkQQe5E0YuVB5M hGBaoENCOmjOssyZ9zHxVkxuI7F9yNeq2fQ1Gzb/Na9nIENnVHPz1U1Uy1do2nmPSTbf2T70aXeep ig1nCP2uzoryNfuNCagaYnvigPQCT2FO5awWpO0aOrPX+NF7V2DpVV8n/aF2yjqwE4wxbY9k77xH5 J7u3qh3B6wW2sTMF5xTaM5f/mHkcrWCY9pjdfFcNsDoe7/IzOpuHmS6exCSUmp2e6IIhWBpuayOQh i+ureULhXQGA9XVyMqzqi9COkFpfnxbeGqFZpwidC1/1hPma5pxqu8lBTtYRaoGx3bt8Q76fD/cPD o9B0fRv8MOAHGq+wi3Gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKAzT-0004Fz-Qo; Tue, 15 Oct 2019 00:47:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKAzQ-0004Fe-FG for linux-arm-kernel@lists.infradead.org; Tue, 15 Oct 2019 00:47:05 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 988E42089C; Tue, 15 Oct 2019 00:47:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571100424; bh=XVqGlOyzVGQHZ9hOvBUdLU3ajK2qd0Ivd5OqEzf/XY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=L9NGZ3K9So8Qvzi/fHJnzuXRu0Gkdzgx3NTiN02B3K6V3yxqk1FgGvVmh0q5HLhn0 BLc6J6nMzrAll0JsM/Maj6xFNvv8xbMjVlCmcOTJkRyaC0GLn11FsjO3DmJpFX6YTZ i3xGyxzEeYnO1WUdttjbv0X4sMtoJ/rRJzI9bsaI= Date: Tue, 15 Oct 2019 01:46:59 +0100 From: Will Deacon To: Mike Rapoport Subject: Re: [PATCH v4] arm64: use generic free_initrd_mem() Message-ID: <20191015004659.l5xbxv4mlpzqpsdl@willie-the-truck> References: <1569657746-31672-1-git-send-email-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569657746-31672-1-git-send-email-rppt@kernel.org> User-Agent: NeoMutt/20170113 (1.7.2) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191014_174704_533541_AF3C569C X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Anshuman Khandual , Catalin Marinas , linux-kernel@vger.kernel.org, Mike Rapoport , Laura Abbott , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 28, 2019 at 11:02:26AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > arm64 calls memblock_free() for the initrd area in its implementation of > free_initrd_mem(), but this call has no actual effect that late in the boot > process. By the time initrd is freed, all the reserved memory is managed by > the page allocator and the memblock.reserved is unused, so the only purpose > of the memblock_free() call is to keep track of initrd memory for debugging > and accounting. > > Without the memblock_free() call the only difference between arm64 and the > generic versions of free_initrd_mem() is the memory poisoning. > > Move memblock_free() call to the generic code, enable it there > for the architectures that define ARCH_KEEP_MEMBLOCK and use the generic > implementation of free_initrd_mem() on arm64. > > Signed-off-by: Mike Rapoport > --- > > v4: > * memblock_free() aligned area around the initrd Looks straightforward to me: Acked-by: Will Deacon Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel