From: Rob Herring <robh@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
f.fainelli@gmail.com, sbranden@broadcom.com,
linux-gpio@vger.kernel.org, rjui@broadcom.com,
linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
richard.laing@alliedtelesis.co.nz, bgolaszewski@baylibre.com,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: gpio: brcm: Add bindings for xgs-iproc
Date: Tue, 15 Oct 2019 14:23:28 -0500 [thread overview]
Message-ID: <20191015192328.GA26346@bogus> (raw)
In-Reply-To: <20191004012525.26647-2-chris.packham@alliedtelesis.co.nz>
On Fri, Oct 04, 2019 at 02:25:24PM +1300, Chris Packham wrote:
> This GPIO controller is present on a number of Broadcom switch ASICs
> with integrated SoCs. It is similar to the nsp-gpio and iproc-gpio
> blocks but different enough to require a separate driver.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> .../bindings/gpio/brcm,xgs-iproc.txt | 41 +++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt
Please make this a DT schema.
>
> diff --git a/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt
> new file mode 100644
> index 000000000000..328b844c82dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/brcm,xgs-iproc.txt
> @@ -0,0 +1,41 @@
> +Broadcom XGS iProc GPIO controller
> +
> +This controller is the Chip Common A GPIO present on a number of Broadcom
> +switch ASICs with integrated SoCs.
> +
> +Required properties:
> +- compatible:
> + Must be "brcm,iproc-gpio-cca"
> +
> +- reg:
> + The first region defines the base I/O address containing
> + the GPIO controller registers. The second region defines
> + the I/O address containing the Chip Common A interrupt
> + registers.
> +
> +Optional properties:
> +
> +- interrupts:
> + The interrupt shared by all GPIO lines for this controller.
> +
> +- #interrupt-cells:
> + Should be <2>. The first cell is the GPIO number, the second should specify
> + flags.
> +
> + See also Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> +- interrupt-controller:
> + Marks the device node as an interrupt controller
> +
> +Example:
> + gpioa: gpio@18000060 {
> + compatible = "brcm,iproc-gpio-cca";
> + #gpio-cells = <2>;
Not documented...
> + reg = <0x18000060 0x50>,
> + <0x18000000 0x50>;
> + ngpios = <12>;
Not documented.
> + gpio-controller;
Not documented.
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> + };
> --
> 2.23.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-15 19:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 1:25 [PATCH 0/2] gpio: brcm: XGS iProc GPIO driver Chris Packham
2019-10-04 1:25 ` [PATCH 1/2] dt-bindings: gpio: brcm: Add bindings for xgs-iproc Chris Packham
2019-10-15 19:23 ` Rob Herring [this message]
2019-10-04 1:25 ` [PATCH 2/2] gpio: Add xgs-iproc driver Chris Packham
2019-10-04 3:01 ` kbuild test robot
2019-10-04 3:30 ` kbuild test robot
2019-10-11 7:43 ` Linus Walleij
2019-10-13 22:08 ` Chris Packham
2019-10-16 12:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015192328.GA26346@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=richard.laing@alliedtelesis.co.nz \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).