From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA484FA3728 for ; Wed, 16 Oct 2019 12:55:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A995A218DE for ; Wed, 16 Oct 2019 12:55:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PrMCLKvz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A995A218DE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A8wuAVNZhyAHgNAadBlTHLvE8aPvabHpCrVlDY5JbAw=; b=PrMCLKvzgOQikF IIDNZqkOnqViTKG56x+RMq6tOQl/FJLU5zBlau8q1L6Uj9oe2DDMsHHFpuzrPviay9Gq21nVtY/aU WwhxiXM9II+2Mo+2Qt4+F+D0URmNnHoFi95C8NUOqqWXUqe1tjnbdPaN/9ZX5eSuwjzvNLgHycFt+ lzM1scP71JF8pkcF3fSSB5izT2+TYpNSo11uxIJs8LWYkVxTgkHmnoIa6VE5IEEBqkCPmqlBHo835 A1dDvBU4L2IUTizR/IgdIgiUuhfYTDZyBUYHAUAKmruhOf4sOPW/YijeenvPU/cgafF1uzj4RiTMt W3J+kEB8XaZDjK7l2QHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKiqD-0002bb-TT; Wed, 16 Oct 2019 12:55:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKiqA-0002Zi-N2 for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 12:55:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6EB3528; Wed, 16 Oct 2019 05:55:43 -0700 (PDT) Received: from arrakis.emea.arm.com (unknown [10.1.196.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2F6E33F68E; Wed, 16 Oct 2019 05:55:42 -0700 (PDT) Date: Wed, 16 Oct 2019 13:55:39 +0100 From: Catalin Marinas To: Mike Rapoport Subject: Re: [PATCH v4] arm64: use generic free_initrd_mem() Message-ID: <20191016125539.GH49619@arrakis.emea.arm.com> References: <1569657746-31672-1-git-send-email-rppt@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1569657746-31672-1-git-send-email-rppt@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_055546_795418_9018BD0D X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Anshuman Khandual , linux-kernel@vger.kernel.org, Mike Rapoport , Laura Abbott , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Sep 28, 2019 at 11:02:26AM +0300, Mike Rapoport wrote: > From: Mike Rapoport > > arm64 calls memblock_free() for the initrd area in its implementation of > free_initrd_mem(), but this call has no actual effect that late in the boot > process. By the time initrd is freed, all the reserved memory is managed by > the page allocator and the memblock.reserved is unused, so the only purpose > of the memblock_free() call is to keep track of initrd memory for debugging > and accounting. > > Without the memblock_free() call the only difference between arm64 and the > generic versions of free_initrd_mem() is the memory poisoning. > > Move memblock_free() call to the generic code, enable it there > for the architectures that define ARCH_KEEP_MEMBLOCK and use the generic > implementation of free_initrd_mem() on arm64. > > Signed-off-by: Mike Rapoport Queued for 5.5. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel