From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52283CA9EA3 for ; Fri, 18 Oct 2019 09:53:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19D55222C3 for ; Fri, 18 Oct 2019 09:53:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LwK+yhhZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n28OxGit" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 19D55222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r2ygHzQwAlHTBFC03vsDBwnKlOtu8IheR8+hdXE7GhI=; b=LwK+yhhZ7V2L/N pqvlxa1HD9y3z6LxWwg53W7PN2HLSZJADQd3BDL9/YSHp0+mw0zf0Xl+jUBnFbx2aEjugGG6j1o8i fgvHEq9JFstwz08pD7fOhRfnvAfeZcEPAR4giqLKk+89ocIc7yCWh5F0G7iofsNwlmn1CPAGB9vh+ P2qhzzNuJYrSI0ssGrBJN60ojivkRXzaOIIuLt6OX5PPR56xXK1bT1k3P6ac+wbsSdkdYrD/Q+EoQ 0hPab1ajYEuTkaZUuvjFiKnAPTlbDO4tHVd1PKZdzvmheCQZHyG0OCyYaOGpfUoXndMjDERpjLrGl kOnyvJs9DfPPU62iqBxw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOwW-0000ck-Ci; Fri, 18 Oct 2019 09:53:08 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iLOwT-0000aG-3v for linux-arm-kernel@lists.infradead.org; Fri, 18 Oct 2019 09:53:06 +0000 Received: by mail-pf1-x443.google.com with SMTP id h195so3549987pfe.5 for ; Fri, 18 Oct 2019 02:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PGk9J+4Cve7nPzhB48lXZkSk8jD7RUn6XtFGq2ZdcE4=; b=n28OxGityoZDMnTZJXc8oRsZQcZHor+VKmgC6rBmcaS7on08zd2eWAFv06U/ZiSHk6 9Lw8fUIWzMB6DMmUXmMNoKxdNKX0NF4jQCmhVVthlNpOhD2eKdor/MF6yaXkFzninruu cmzLJ2wHqbw1r9bS+WsEPgxmkgSt/E1yg7CKLON6iqE6joGCQR9KMjskL+l2KsIqdXmR F/VtfVlR4O0W1D9MWmMnF8DFcSRaOM+ZZvYUoJZsat8VUP/QR7rz1p4SE1GJkwYpTN+a X4hbuvWfGb1KTL73kiiUTCAn605J1ZE4Mz5ly7rR37WtyirV/Qs97aNCLdY3VnhQsu34 NNlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PGk9J+4Cve7nPzhB48lXZkSk8jD7RUn6XtFGq2ZdcE4=; b=GHTUWKjqeEuHeOJsdDRgF+S5LGWgUYJGivNQxaz2GZ4dPvl4GzaAABEvCOJ3k9Bfji b5WEUvWoFSs0QF4udaQRZY6vG0RvyC5cyRUe41c1ZoYRL4pX83Z2i3cWibNzKWQNbCr8 485vd6kFIWM0icJq/nqrlI2UlMuQgtmuQ0aAJIr2YALjckzJL5FB9SfjS37zv9fcp7pV wC5V6bxZTprot4tt9YNgvh4nAiXm7k5F+xDu77JZmrJ2AIhKkrtNog8YBXUJF3UjNHyk qqLs7Zd6fcLFqvmQ9raW2auDNi025ID0fEwUDJ8ew+nchAVOauzrYyY7CuwT7B9PNcwV 3yOQ== X-Gm-Message-State: APjAAAWWoWDBnFBOxe8LDdwLTitdmHkDo2xCf9SiK5uSCoMoD8CT11+A ir06U7MKsuGW+CNhZcdYlPOOyw== X-Google-Smtp-Source: APXvYqxlPmABURKMNZR4TlIqRnlfd/HOkYCVCXPKQWozAwch1z3PnRODRY9cczTpXXYxPHhWt0UqUQ== X-Received: by 2002:a63:ec4f:: with SMTP id r15mr9050130pgj.17.1571392383198; Fri, 18 Oct 2019 02:53:03 -0700 (PDT) Received: from localhost ([122.172.151.112]) by smtp.gmail.com with ESMTPSA id l62sm6471028pfl.167.2019.10.18.02.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Oct 2019 02:53:02 -0700 (PDT) Date: Fri, 18 Oct 2019 15:23:00 +0530 From: Viresh Kumar To: "andrew-sh.cheng" Subject: Re: [v4, 7/8] cpufreq: mediatek: add opp notification for SVS support Message-ID: <20191018095300.mtygp2ej7rnz6uzn@vireshk-i7> References: <1565703113-31479-1-git-send-email-andrew-sh.cheng@mediatek.com> <1565703113-31479-8-git-send-email-andrew-sh.cheng@mediatek.com> <20190820033927.72muldasu4xd6wb7@vireshk-i7> <1571193828.22071.5.camel@mtksdaap41> <20191017063102.4jirlphdxdydl2bm@vireshk-i7> <1571389431.27207.4.camel@mtksdaap41> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1571389431.27207.4.camel@mtksdaap41> User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191018_025305_158353_545BCAAE X-CRM114-Status: GOOD ( 15.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Nishanth Menon , srv_heupstream , "linux-pm@vger.kernel.org" , Stephen Boyd , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Rob Herring , Chanwoo Choi , Kyungmin Park , MyungJoo Ham , "linux-mediatek@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , Matthias Brugger , Fan Chen =?utf-8?B?KOmZs+WHoSk=?= , "devicetree@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18-10-19, 17:03, andrew-sh.cheng wrote: > On Thu, 2019-10-17 at 12:01 +0530, Viresh Kumar wrote: > > On 16-10-19, 10:43, andrew-sh.cheng wrote: > > > This is due to SVS feature need to fix Vproc for calibration. > > > When SVS calibration, it want to disable all opp items, except one with > > > voltae 1.0V. (SVS will change the voltage field of that opp item, if the > > > corresponding voltage is not 1.0V) > > > In this way, SVS can make sure there is no other module, include > > > thermal, will change Vproc by DVFS driver. > > > After SVS calibration done, SVS will enable those disabled opp items > > > back. > > > > But why is this required to be done this way ? Why can't we just update the > > voltages without doing this disable/enable dance ? > > > This is because some opp items need voltage larger than 1.0V. > We cannot update the voltage to 1.0V. > > If we don't disable these opp items, and DVFS policy want to set these > high frequencies, dvfs driver will set higher voltage to Vproc and SVS > calibration will be fail. Okay. -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel