From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] do not export show_fiq_list
Date: Fri, 18 Oct 2019 12:17:58 +0100 [thread overview]
Message-ID: <20191018111757.GH25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191018103513.24096-1-ben.dooks@codethink.co.uk>
On Fri, Oct 18, 2019 at 11:35:13AM +0100, Ben Dooks (Codethink) wrote:
> The show_fiq_list() is not used outside the file it is
> defined in, so make it static and remove the header
> file declaration (which it did not include) to remove
> the following sparse warning:
>
> arch/arm/kernel/fiq.c:85:5: warning: symbol 'show_fiq_list' was not declared. Should it be static?
NAK. This is called from arch/arm/kernel/irq.c; making it static will
create a link failure.
Please don't take sparse "suggestions" as the correct solution, always
research the warning thoroughly before coming up with a solution. In
this case:
$ grep -r show_fiq_list arch/arm
would have shown why this change is wrong.
Thanks.
>
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/include/asm/mach/irq.h | 1 -
> arch/arm/kernel/fiq.c | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/include/asm/mach/irq.h b/arch/arm/include/asm/mach/irq.h
> index dfe832a3bfc7..fcc5667c7cea 100644
> --- a/arch/arm/include/asm/mach/irq.h
> +++ b/arch/arm/include/asm/mach/irq.h
> @@ -15,7 +15,6 @@ struct seq_file;
> * This is internal. Do not use it.
> */
> extern void init_FIQ(int);
> -extern int show_fiq_list(struct seq_file *, int);
>
> /*
> * This is for easy migration, but should be changed in the source
> diff --git a/arch/arm/kernel/fiq.c b/arch/arm/kernel/fiq.c
> index cd1234c103fc..693d0b35acc4 100644
> --- a/arch/arm/kernel/fiq.c
> +++ b/arch/arm/kernel/fiq.c
> @@ -82,7 +82,7 @@ static struct fiq_handler default_owner = {
>
> static struct fiq_handler *current_fiq = &default_owner;
>
> -int show_fiq_list(struct seq_file *p, int prec)
> +static int show_fiq_list(struct seq_file *p, int prec)
> {
> if (current_fiq != &default_owner)
> seq_printf(p, "%*s: %s\n", prec, "FIQ",
> --
> 2.23.0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-18 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 10:35 [PATCH] do not export show_fiq_list Ben Dooks (Codethink)
2019-10-18 10:44 ` Ben Dooks
2019-10-18 11:17 ` Russell King - ARM Linux admin [this message]
2019-10-18 11:20 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018111757.GH25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=ben.dooks@codethink.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@lists.codethink.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).