From: Daniel Thompson <daniel.thompson@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: arnd@arndb.de, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, broonie@kernel.org,
dilinger@queued.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries
Date: Fri, 18 Oct 2019 17:06:36 +0100 [thread overview]
Message-ID: <20191018160636.pt4im3m3hlruobms@holly.lan> (raw)
In-Reply-To: <20191018125608.5362-4-lee.jones@linaro.org>
On Fri, Oct 18, 2019 at 01:56:07PM +0100, Lee Jones wrote:
> CS5535 is the only user of mfd_clone_cell(). It makes more sense to
> register child devices in the traditional way and remove the quite
> bespoke mfd_clone_cell() call from the MFD API.
Like the other thread... this looks like it takes a shared (cloned)
reference counter and creates two independant ones instead.
Daniel.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/cs5535-mfd.c | 34 +++++++++++++++++++++++++++++-----
> 1 file changed, 29 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/cs5535-mfd.c b/drivers/mfd/cs5535-mfd.c
> index b01e5bb4ed03..2711e6e42742 100644
> --- a/drivers/mfd/cs5535-mfd.c
> +++ b/drivers/mfd/cs5535-mfd.c
> @@ -95,9 +95,23 @@ static struct mfd_cell cs5535_mfd_cells[] = {
> },
> };
>
> -static const char *olpc_acpi_clones[] = {
> - "olpc-xo1-pm-acpi",
> - "olpc-xo1-sci-acpi"
> +static struct mfd_cell cs5535_olpc_mfd_cells[] = {
> + {
> + .name = "olpc-xo1-pm-acpi",
> + .num_resources = 1,
> + .resources = &cs5535_mfd_resources[ACPI_BAR],
> +
> + .enable = cs5535_mfd_res_enable,
> + .disable = cs5535_mfd_res_disable,
> + },
> + {
> + .name = "olpc-xo1-sci-acpi",
> + .num_resources = 1,
> + .resources = &cs5535_mfd_resources[ACPI_BAR],
> +
> + .enable = cs5535_mfd_res_enable,
> + .disable = cs5535_mfd_res_disable,
> + },
> };
>
> static int cs5535_mfd_probe(struct pci_dev *pdev,
> @@ -130,8 +144,18 @@ static int cs5535_mfd_probe(struct pci_dev *pdev,
> goto err_disable;
> }
>
> - if (machine_is_olpc())
> - mfd_clone_cell("cs5535-acpi", olpc_acpi_clones, ARRAY_SIZE(olpc_acpi_clones));
> + if (machine_is_olpc()) {
> + err = mfd_add_devices(&pdev->dev, PLATFORM_DEVID_NONE,
> + cs5535_olpc_mfd_cells,
> + ARRAY_SIZE(cs5535_olpc_mfd_cells),
> + NULL, 0, NULL);
> + if (err) {
> + dev_err(&pdev->dev,
> + "Failed to add CS5532 OLPC sub-devices: %d\n",
> + err);
> + goto err_disable;
> + }
> + }
>
> dev_info(&pdev->dev, "%zu devices registered.\n",
> ARRAY_SIZE(cs5535_mfd_cells));
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-18 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 12:56 [PATCH 0/4] Remove mfd_clone_cell() from the MFD API Lee Jones
2019-10-18 12:56 ` [PATCH 1/4] mfd: cs5535-mfd: Use PLATFORM_DEVID_* defines and tidy error message Lee Jones
2019-10-18 12:56 ` [PATCH 2/4] mfd: cs5535-mfd: Remove mfd_cell->id hack Lee Jones
2019-10-18 16:54 ` Daniel Thompson
2019-10-18 12:56 ` [PATCH 3/4] mfd: cs5535-mfd: Register clients using their own dedicated MFD cell entries Lee Jones
2019-10-18 16:06 ` Daniel Thompson [this message]
2019-10-18 12:56 ` [PATCH 4/4] mfd: mfd-core: Remove mfd_clone_cell() Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018160636.pt4im3m3hlruobms@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=dilinger@queued.net \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).