From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37E80CA9EA0 for ; Tue, 22 Oct 2019 15:47:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04FDF214B2 for ; Tue, 22 Oct 2019 15:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lkvsMwBB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04FDF214B2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S95CfhukQgDjJtgB8QjV9Qr+m0SEn/0GJg4iBtoozRE=; b=lkvsMwBBau4zFL zKjfiQqSupNGWyPK9iRK4jgpIqC3CvPzq7XJc4JA1VX2jVxHy+gdPhao5xcEU3RfTQkMA5AvDEKRv /+8RDZqFCmTtP5krwNLFayFAYMTpWkgHc+xFd1JzJFabE7C6ktfFOY2rAW0iW9Ywe3wb+NwrZamV2 T9gV/43w44rJ+5Ux1tqAsJya0d5W+XZ3bHZfcbxa8qbB4U843fz2jl/Fgi+aJxmEHHep6MESxLG9L tkMaO2ZxbdQVtjIUqr18GHRg64n+pb/w4fm3BGtcjK0wq6gP/Lqs3aSFUUl3ht0U6r3lAJJk03UeP wb4FoWsAsc0a3hqZZbKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMwNg-0005Od-CI; Tue, 22 Oct 2019 15:47:32 +0000 Received: from [217.140.110.172] (helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMwNd-0005NO-MT for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 15:47:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 977AC177F; Tue, 22 Oct 2019 08:47:18 -0700 (PDT) Received: from lakrids.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E54FC3F71A; Tue, 22 Oct 2019 08:47:16 -0700 (PDT) Date: Tue, 22 Oct 2019 16:47:08 +0100 From: Mark Rutland To: Sami Tolvanen Subject: Re: [PATCH 13/18] arm64: preserve x18 when CPU is suspended Message-ID: <20191022154708.GA699@lakrids.cambridge.arm.com> References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-14-samitolvanen@google.com> <20191021165649.GE56589@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1+11 (2f07cb52) (2018-12-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_084729_778965_23AFBB23 X-CRM114-Status: UNSURE ( 9.32 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Ard Biesheuvel , Catalin Marinas , Kernel Hardening , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , Laura Abbott , Will Deacon , Dave Martin , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 21, 2019 at 03:43:14PM -0700, Sami Tolvanen wrote: > On Mon, Oct 21, 2019 at 9:56 AM Mark Rutland wrote: > > This should have a corresponding change to cpu_suspend_ctx in > > . Otherwise we're corrupting a portion of the stack. > > Ugh, correct. I'll fix this in the next version. Thanks. It's probably worth extending the comment above cpu_do_suspend to say: | This must be kept in sync with struct cpu_suspend_ctx in | ... to match what we have above struct cpu_suspend_ctx, and make this more obvious in future. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel