From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 185FBCA9EA0 for ; Tue, 22 Oct 2019 22:19:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DC97220700 for ; Tue, 22 Oct 2019 22:19:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MDe+wNVL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DC97220700 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FXnNXV+D9UucWNFPRDdFlzZX4GiFNLG2m/PYYxTTcsc=; b=MDe+wNVLm4Ohuh Rbd+VZfA4fLYrZql5CKuNUgRqE0KJtgFtx8Rf1MHq2NJe3FJiWgjahK+MAICwcsjxc7pFcUrHv/8/ rDe8/eoTCamZFYks3JAPDAWmRziOzc5KAMJvABpT13pqfje2DN+vVnR3k/o7R8ilpbtysTsldmGxQ 5AfUhsCrsxZiSjfoBSNUmZc0U1SArjN23xgrz0j4nt0PcYz8w7sFADph/VkBycpxDcduLCGhMbBw0 hsR/jtLCLW3jylLxnFZacHmnhiyNRkoV2Jz/S2z3DKbMVB19uTI9L/duV3LpLbZh+DhfSSw/u7RIu xv8h6Cai2MulOa27zR0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iN2Uz-00060p-Sh; Tue, 22 Oct 2019 22:19:29 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iN2Uv-00060J-Rz for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 22:19:28 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 88D5080FA; Tue, 22 Oct 2019 22:19:57 +0000 (UTC) Date: Tue, 22 Oct 2019 15:19:19 -0700 From: Tony Lindgren To: Adam Ford Subject: Re: [PATCH 1/2] configs: ARM: omap2plus: Enable OMAP3_THERMAL Message-ID: <20191022221919.GF5610@atomide.com> References: <20191007220540.30690-1-aford173@gmail.com> <20191022162223.GU5610@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_151925_943473_B123BC9A X-CRM114-Status: GOOD ( 23.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , "H. Nikolaus Schaller" , Russell King , Linux Kernel Mailing List , Rob Herring , =?utf-8?Q?Beno=C3=AEt?= Cousson , Linux-OMAP , Adam Ford , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Adam Ford [191022 19:01]: > On Tue, Oct 22, 2019 at 11:22 AM Tony Lindgren wrote: > > > > Hi, > > > > * Adam Ford [191007 15:06]: > > > The some in the OMAP3 family have a bandgap thermal sensor, but > > > omap2plus has it disabled. > > > > > > This patch enables the OMAP3_THERMAL by default like the rest of > > > the OMAP family. > > > > Looks like this breaks off mode during idle for omap3, and that's > > probably why it never got enabled. The difference in power > > consumption during idle is about 7mW vs 32mW for the SoC as > > measured from torpedo shunt for main_battery_som. > > > > I think the right fix might be simply to add handling for > > CPU_CLUSTER_PM_ENTER to the related thermal driver to disable > > it during idle like we have for gpio-omap.c for example. > > I am not sure I know where to start on fixing that issue. Would you > entertain enabling the driver if we set the device tree to 'disabled' > by default? This way if people want to to use it, it can be enabled > on a per-device option. Once the power stuff gets resolved, we might > be able to enable it by default. For people who are planning on using > the DM3730 @ 1GHz in high temp environments, I am not sure they'll > care about low power. They should both work fine together though. They are not mutually exclusive features. > I'll try to look into it when I have time, but I was hoping a > compromise might be a reasonable work-around. It should be hopefully a trivial fix.. I have not looked at the driver code though. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel