From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 387CDCA9EAF for ; Wed, 30 Oct 2019 06:46:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E05320874 for ; Wed, 30 Oct 2019 06:46:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J+Ygxird"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aF/kblen" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E05320874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G4Yt0uGisgqQNUKqG4G0hRhn6W5eeGIsfQOnwNgL4xo=; b=J+YgxirdAY/iR/ sV4/x6kU64v62q9hsuwTC8Y5DF2n3sLuIU4kHP+LfrdvoNjjNMfQGiKoC4WDyzh7GqrVLTfFbOGOh Vu+POiS5DKdhqilkYkEEDMfQI26pw38qtXYFpbW5LVZ9vYaUTo7gfaHxa/kUqpG3dvrrc2X7lUZwg YoIrecHEMQrO6OyRWMGb3k6xcL0V1InqvKkAe/od6V+wDFZ/bOykOzREuZiwiOQ8CjzHGm7apJ/jV 2P1QvzNK9u3+B31mgo0yIyvxc12xIenl6VXN0M5YFF0pgdjz81Sg5pyZGCHwOjda/JFiaGWkRmtrS ns8lbOCRTs7QOtFKGLig==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPhk9-0000Dh-2T; Wed, 30 Oct 2019 06:46:09 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPhk5-0000Cm-PJ for linux-arm-kernel@lists.infradead.org; Wed, 30 Oct 2019 06:46:07 +0000 Received: by mail-pg1-x543.google.com with SMTP id l3so793631pgr.8 for ; Tue, 29 Oct 2019 23:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=cUna80mgrJuvwZng2S/zg9eJ2aJtl1v9W/4Z7bansiw=; b=aF/kblen9t7CI7DHz9bX09InKfJirCrxV3h4upoRTtuntFzgf+ordcplUGhDX3hTlI enA6URTjG0DKHNBi7J0mrKJnZ4kpZEXgZiuT0h9iNBlprIQJyJtZIMrytcelto9jQO7H MsopDsGzlopi41nNk+mnCl/lntEhDo13NN+XSceDsf0olDyv6lrE4MwZ8tOAOOOVRf37 hs6uKnu6Ueo6jwa5fJv4IwEn/6bbxawQmu6ZcBnZkngNeMEiroT/u7fHnv6vpuw5IYke qnmMpHgGEebHdKWzYqH8bpUg+biG8CfvSfTg7sNHuFlVv8ytyegGt6zi0ypgzbIHLwXW LJDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=cUna80mgrJuvwZng2S/zg9eJ2aJtl1v9W/4Z7bansiw=; b=cnH/8GIA+VCDeMGbx56/eodii4L92phiw04d78oRr1uCKUJvjnL+z5mo6e+/VpLfob QAHCGcLs5FzqAZQbBhj0ViZ+FrbnwmDIVolTWyk3wsNaJjMXh59+L8wlqt34U29HY31L W/0m+AtkKlQjJYUvsE2ZWANn+g2YC2LYVvfp1cI6+J1yLjFYulxurllEbmw8aXXtHBZV ZDco4kQUP0I1vZimJWl71oj7pWD9pbY5fkp7nnAnJKtqFPy1rGUwQyJfXIrx/0Bsv701 bVqHKwrfw7eTpDHpI0rxB8WpZCg0yPNoqv+mqXgihTWNGiZAigr7FFn4592lGEhFmP97 TBFw== X-Gm-Message-State: APjAAAXLzZEigOlPynmJiHOt1hMAdaTcJbrrC993b1jmiE+PCG6QHw6D lVxQOTJKdkdRwl3PLUPjzLYs X-Google-Smtp-Source: APXvYqw4sy47eUnhMCq6S6rBb149xzsVxBxXpwL1klsrmUeuNOV3Z+gzN5hBEkI38UsF/yJrZuzh7A== X-Received: by 2002:a63:f441:: with SMTP id p1mr31930177pgk.362.1572417964721; Tue, 29 Oct 2019 23:46:04 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2409:4072:618e:77d9:c9fa:423a:3851:8df4]) by smtp.gmail.com with ESMTPSA id i63sm1270378pgc.31.2019.10.29.23.45.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Oct 2019 23:46:04 -0700 (PDT) Date: Wed, 30 Oct 2019 12:15:55 +0530 From: Manivannan Sadhasivam To: Rob Herring , Sakari Ailus Subject: Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add IMX296 CMOS sensor binding Message-ID: <20191030064555.GB11637@Mani-XPS-13-9360> References: <20191025175908.14260-1-manivannan.sadhasivam@linaro.org> <20191025175908.14260-2-manivannan.sadhasivam@linaro.org> <20191028122115.GB4928@valkosipuli.retiisi.org.uk> <20191029221213.GB17996@bogus> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191029221213.GB17996@bogus> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_234605_831882_4FC2F77A X-CRM114-Status: GOOD ( 23.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, c.barrett@framos.com, linux-kernel@vger.kernel.org, a.brela@framos.com, peter.griffin@linaro.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Sakari, On Tue, Oct 29, 2019 at 05:12:13PM -0500, Rob Herring wrote: > On Mon, Oct 28, 2019 at 02:21:15PM +0200, Sakari Ailus wrote: > > Hi Manivannan, > > > > Thanks for the update. > > > > On Fri, Oct 25, 2019 at 11:29:07PM +0530, Manivannan Sadhasivam wrote: > > > Add YAML devicetree binding for IMX296 CMOS image sensor. > > > > > > Signed-off-by: Manivannan Sadhasivam > > > --- > > > .../devicetree/bindings/media/i2c/imx296.yaml | 98 +++++++++++++++++++ > > > 1 file changed, 98 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx296.yaml b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > new file mode 100644 > > > index 000000000000..4e204fd7cf90 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/imx296.yaml > > > @@ -0,0 +1,98 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/imx296.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Sony IMX296 1/2.8-Inch CMOS Image Sensor > > > + > > > +maintainers: > > > + - Manivannan Sadhasivam > > > + > > > +description: |- > > > + The Sony IMX296 is a 1/2.9-Inch active pixel type CMOS Solid-state image > > > + sensor with square pixel array and 1.58 M effective pixels. This chip > > > + features a global shutter with variable charge-integration time. It is > > > + programmable through I2C and 4-wire interfaces. The sensor output is > > > + available via CSI-2 serial data output (1 Lane). > > > + > > > +properties: > > > + compatible: > > > + const: sony,imx296 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + description: > > > + Input clock for the sensor. > > > + items: > > > + - const: mclk > > > + > > > + clock-frequency: > > > + description: > > > + Frequency of the mclk clock in Hertz. > > > + default: 37125000 > > > > I think you could omit the default. > > Yes, there's no default if it is required. > Okay. > > > + > > > + vddo-supply: > > > + description: > > > + Definition of the regulator used as interface power supply. > > > + maxItems: 1 > > > + > > > + vdda-supply: > > > + description: > > > + Definition of the regulator used as analog power supply. > > > + maxItems: 1 > > > + > > > + vddd-supply: > > > + description: > > > + Definition of the regulator used as digital power supply. > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + description: > > > + The phandle and specifier for the GPIO that controls sensor reset. > > > + maxItems: 1 > > > + > > > + # See ../video-interfaces.txt for details > > details on what? > Standard properties like endpoint, reg, etc... I can remove it if not required. > > > + > > > +required: > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - clock-frequency > > > + - vddo-supply > > > + - vdda-supply > > > + - vddd-supply > > > > I think the port and endpoint nodes should documented here as well. > > port yes, but endpoint no. Unless you have endpoint properties other > than remote-endpoint or reg. > Okay. Will document port. Thanks, Mani > > > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + #include > > > + > > > + imx296: camera-sensor@1a { > > > + compatible = "sony,imx296"; > > > + reg = <0x1a>; > > > + reset-gpios = <&msmgpio 35 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 = <&camera_rear_default>; > > > + clocks = <&gcc 90>; > > > + clock-names = "mclk"; > > > + clock-frequency = <37125000>; > > > + vddo-supply = <&camera_vddo_1v8>; > > > + vdda-supply = <&camera_vdda_3v3>; > > > + vddd-supply = <&camera_vddd_1v2>; > > > + > > > + port { > > > + imx296_ep: endpoint { > > > + remote-endpoint = <&csiphy0_ep>; > > > + }; > > > + }; > > > + }; > > > + > > > +... > > > > -- > > Regards, > > > > Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel