From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: linus.walleij@linaro.org, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com
Cc: linux-gpio@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/2] pinctrl: bcm: nsp: gpio improvements
Date: Mon, 4 Nov 2019 13:18:17 +1300 [thread overview]
Message-ID: <20191104001819.2300-1-chris.packham@alliedtelesis.co.nz> (raw)
I'm working on a platform using the BCM 58525 SoC. I noticed that some of
the peripherals were being deferred (not that that's a problem) and debugfs
was complaining "File ':axi@18000000:gpio@20' in directory 'domains' already
present!" which is more of a sign that things were not right.
The debugfs error was because the manually created irq domain was not
cleaned up on failure (or deferral).
I've dropped the patch from this series that changes the order in the
device tree. I can probably live with the deferrals.
While I was debugging another issue I noticed my gpio-hogs weren't
showing up correctly in /sys/kernel/debug/gpio. At first I thought I was
missing commit d95da993383c ("gpiolib: Preserve desc->flags when setting
state") but as it turns out pinctrl-nsp-gpio.c didn't provide a
get_direction function so the generic code assumed they all started as
inputs. I've added a new patch to address that.
Chris Packham (2):
pinctrl: bcm: nsp: use gpiolib infrastructure for interrupts
pinctrl: bcm: nsp: implement get_direction
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 119 ++++++++++++-------------
1 file changed, 56 insertions(+), 63 deletions(-)
--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-11-04 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 0:18 Chris Packham [this message]
2019-11-04 0:18 ` [PATCH v3 1/2] pinctrl: bcm: nsp: use gpiolib infrastructure for interrupts Chris Packham
2019-11-04 15:20 ` Linus Walleij
2019-11-04 0:18 ` [PATCH v3 2/2] pinctrl: bcm: nsp: implement get_direction Chris Packham
2019-11-04 15:20 ` Linus Walleij
2019-11-04 15:24 ` Linus Walleij
2019-11-04 19:58 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104001819.2300-1-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).