From: Pavel Machek <pavel@ucw.cz>
To: Stefan Wahren <wahrenst@gmx.net>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>,
Linus Walleij <linus.walleij@linaro.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Eric Anholt <eric@anholt.net>, Rob Herring <robh+dt@kernel.org>,
bcm-kernel-feedback-list@broadcom.com,
Dan Murphy <dmurphy@ti.com>,
linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue
Date: Mon, 4 Nov 2019 10:09:19 +0100 [thread overview]
Message-ID: <20191104090919.GC12355@duo.ucw.cz> (raw)
In-Reply-To: <1570964003-20227-1-git-send-email-wahrenst@gmx.net>
[-- Attachment #1.1: Type: text/plain, Size: 1106 bytes --]
On Sun 2019-10-13 12:53:23, Stefan Wahren wrote:
> bcm2835-rpi.dtsi defines the behavior of the ACT LED, which is available
> on all Raspberry Pi boards. But there is no driver for this particual
> GPIO on CM3 in mainline yet, so this node was left incomplete without
> the actual GPIO definition. Since commit 025bf37725f1 ("gpio: Fix return
> value mismatch of function gpiod_get_from_of_node()") this causing probe
> issues of the leds-gpio driver for users of the CM3 dtsi file.
>
> leds-gpio: probe of leds failed with error -2
>
> Until we have the necessary GPIO driver hide the ACT node for CM3
> to avoid this.
>
> Reported-by: Fredrik Yhlen <fredrik.yhlen@endian.se>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> Fixes: a54fe8a6cf66 ("ARM: dts: add Raspberry Pi Compute Module 3 and IO board")
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-04 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 10:53 [PATCH] ARM: dts: bcm2837-rpi-cm3: Avoid leds-gpio probing issue Stefan Wahren
2019-10-18 18:59 ` Florian Fainelli
2019-11-04 9:09 ` Pavel Machek [this message]
2019-11-04 17:03 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104090919.GC12355@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=krzk@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).