From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 175E7CA9ECF for ; Mon, 4 Nov 2019 15:50:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD80D20869 for ; Mon, 4 Nov 2019 15:50:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PmdooE5M"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="im3j2OBb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD80D20869 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gtP9dp+2DWJQW57BFZlKxO1utqQRCJPvZBxabJUBtHo=; b=PmdooE5MXqXiVq yl8Iq+IUFoB6zt/WBiDhjhNJgzLu+GiKs2NxmwFAYONTZTlUC4UO24yo4sRrnsMbBft/PNbznntCq BXFB9Z8CY8gSbG8nYitLAYa2xqJdUbu0ZeoB3Xx3bhUmX0Oempm6irxDTA8/brkFeTHnYGAELrVzj u23kqPnrls37HM/oIRsfdik/n/abA5VJN7oyqN0M9Bd/QcUzVyH34BwqVGD+wY8N6k6cdu5cS15mq ZdbWbcleOpobhGcJBj9VFdcNH5ibcek9kAPZm3cfwBeb1422BBY6tVypyFIEa73Rut0V7lYUBnTdH QNEbdKznF/v11INo78Tg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRecE-0003kU-SW; Mon, 04 Nov 2019 15:50:02 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iRecB-0003g2-Ao for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2019 15:50:00 +0000 Received: by mail-wm1-x343.google.com with SMTP id f3so5483588wmc.5 for ; Mon, 04 Nov 2019 07:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Gh6ypC21DF1xtMKX6b7wG5FsVhzjCIpzo9aEJOM0Ec=; b=im3j2OBbbqi4Fc6j0I3KRw5w3dJD+PpY4wjlEOrP3B2bqWJXjq6Oj32CwXt0fiDWYl qkQ/1govBFgqO8lDQVfxIGGJUi49jLWrDdMOuFl8Ei5jLh37feq4/6FWPDec/b+/DSNe YGtfjOwAf0mi/fXBruyCTSbdQrwEnefKsA9FwF0BgQxNj7r6tdv2kunbNFtyCMfBONrb ddgigulvNajaQblYrKEq59EZYeEP56Me8KgDwW8MahMr17IWkEJp8pp5+iU4T3syzFJD Nol9qlrgcq4JSTVIxTz5nZi9+1+SjnMk17x/rwxVBP9cRqHZ/2hxuwOJDGyTNoVjlEmT N25Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5Gh6ypC21DF1xtMKX6b7wG5FsVhzjCIpzo9aEJOM0Ec=; b=LG6cJo0BoQkvGuOx4ZhVHpISj7vIdFE2eptLO4DO1ZBCW15nr4bsu75ckSKObOqAUz wdkRW4CPHCpuiR7DWjAGTyC3DBp+6zUkEsqP3cAmQetnNSXiol/IYQFoFCYAQbtA161c 3L/JE7gnVFXBh45cCxeC3oRVJsrPjjOrA/YjJMTQEde7DRERPPfe9kmRU2CEgPZErtd9 72sCjdG6L6vHytt6ZoRykhtaLSsdLJLiILdRdJeEoYAmHZj5Ed43zkfCduPvuYhuwhv7 iGKldOumS1eVFHv2iemqaZf9DkUyq7ZCRuSMe3dcKZtDPCapnZBodLUddeFOk7KoFDoO fTaw== X-Gm-Message-State: APjAAAW35ZLHMKlDbtxzhX/kfCcSXPAxFUlJAeRmH5hMwCVfM+Iu8oiw nze/wwBeq24G54HlqAp2JX8= X-Google-Smtp-Source: APXvYqxBbQ0WXX+4m67jdYFm9J7caqNO4J9KmFZqX9e2cr9tFfT+cfmL9jbMVOp2qFx+BherG9wLoQ== X-Received: by 2002:a05:600c:28c:: with SMTP id 12mr16472749wmk.25.1572882597179; Mon, 04 Nov 2019 07:49:57 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id i71sm23332521wri.68.2019.11.04.07.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 07:49:56 -0800 (PST) From: Chuhong Yuan To: Subject: [PATCH] media: exynos4-is: add missed clk_disable_unprepare in remove Date: Mon, 4 Nov 2019 23:49:42 +0800 Message-Id: <20191104154942.8935-1-hslester96@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191104_074959_399389_0FED861C X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kyungmin Park , Kukjin Kim , Sylwester Nawrocki , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver forgets to disable and unprepare clock when remove. Add a call to clk_disable_unprepare to fix it. Signed-off-by: Chuhong Yuan --- drivers/media/platform/exynos4-is/fimc-lite.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/exynos4-is/fimc-lite.c b/drivers/media/platform/exynos4-is/fimc-lite.c index e87c6a09205b..6748bd96aada 100644 --- a/drivers/media/platform/exynos4-is/fimc-lite.c +++ b/drivers/media/platform/exynos4-is/fimc-lite.c @@ -1614,6 +1614,7 @@ static int fimc_lite_remove(struct platform_device *pdev) struct fimc_lite *fimc = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; + clk_disable_unprepare(fimc->clock); pm_runtime_disable(dev); pm_runtime_set_suspended(dev); fimc_lite_unregister_capture_subdev(fimc); -- 2.23.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel