From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E96D6C5DF60 for ; Tue, 5 Nov 2019 16:59:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFC8D21D71 for ; Tue, 5 Nov 2019 16:59:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BGfcabXo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OFavqygr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFC8D21D71 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xj1Vgxee1NzPpouPeimThTo9LX+/1VLWJBKYH5mVVqo=; b=BGfcabXo/m0ZRG kCDN5A7ILkXvg8xwMCFD8dbdXiyVaoXVlr0oQ5h0raVM/T3uT6rx/lrXCxMowQou4S+dgelq/Zeec 1LCXP5bPEpK+L6uPxE1zPyqZPyKKxoaeGUGUpUkbHZ/Z7G2PYDQnthZaJgFTKfYJPNxUUydgSG5Ad y95XI5nwAhsd+UC5t8n7O347ZZnN6jZjXvcsyN2euxsYduICIOxjtZSZY2twulQZj6H1uhPli7ECy 8v5Zx7A1k52d3F0g++Bnu9ZHHQmn/85lAL0tP3L9/umbVSNkQ5sqvimTPhGbZRpjh4A2TJcGTnimb oGWxql9DqjZTffOPYgGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS2Aa-0005Os-F1; Tue, 05 Nov 2019 16:59:04 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iS2AW-0005Nq-UB for linux-arm-kernel@lists.infradead.org; Tue, 05 Nov 2019 16:59:02 +0000 Received: from localhost (unknown [106.51.111.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6691E21A4A; Tue, 5 Nov 2019 16:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572973140; bh=/A2do6Mf/FPqPLM4v479lgV7kRc8ywC8Z/ymYhp6rms=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OFavqygrYcNdBWeIIKwJ+n+eOg6AKPGmrReLitjDZaCiWkjp+0njB3pWCDHKLFZTP SysI8QrUX1MoPkun18JjrtBovD5bHCDytIt/aJPY+SQGRy49gplo1SuPo5fPOQqzhu 9iovrOO5Y3/2qhmWoliPXUHB5T4SYIfeTzTk/py0= Date: Tue, 5 Nov 2019 22:28:55 +0530 From: Vinod Koul To: Satendra Singh Thakur Subject: Re: [PATCH] dma/zx/remove: Removed dmam_pool_destroy from remove method Message-ID: <20191105165855.GC952516@vkoul-mobl> References: <20191024041623.24658-1-sst2005@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191024041623.24658-1-sst2005@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191105_085900_992698_27BB57A1 X-CRM114-Status: GOOD ( 13.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Jun Nie , Shawn Guo , Dan Williams , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-10-19, 09:46, Satendra Singh Thakur wrote: > In the probe method dmam_pool_create is used. Therefore, there is no > need to explicitly call dmam_pool_destroy in remove method as this > will be automatically taken care by devres Please do not reinvent system tags, git log is your friend to check for the tags to be used. In this case, it is dmaengine: zx: remove ... > > Signed-off-by: Satendra Singh Thakur > --- > drivers/dma/zx_dma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c > index 9f4436f7c914..7e4e457ac6d5 100644 > --- a/drivers/dma/zx_dma.c > +++ b/drivers/dma/zx_dma.c > @@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op) > list_del(&c->vc.chan.device_node); > } > clk_disable_unprepare(d->clk); > - dmam_pool_destroy(d->pool); > > return 0; > } > -- > 2.17.1 -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel