From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C43C5DF60 for ; Thu, 7 Nov 2019 19:23:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAA12084C for ; Thu, 7 Nov 2019 19:23:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZAA9JtIi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="0hfQhQvl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEAA12084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y8NHQmvek5VvymbhL8oe23lp+ny2d7QgzjVS7M2A/CA=; b=ZAA9JtIiAMmK0n 7vYTWbFvoeNZJXXmIY5pgpo1IdxnfckqGfkeyOurF7IDg/2lnVp2cY79EwMziibD8yapP9tBU0xvP DCOD6ptyr0KUd8hmYYv03z7VMwTegZadjGRANLmdnNalIBJsQxuVecxw7aNvpFce+sUjYgiKWAmkH Y7G84MAJQnCOwJbrsvylsE+dTLBEa7stwCgtK7Ny8QoxPk6V3ECXWpS4Jj6x1ksb/CDfN8DnkW62S Ee6N1gBUvN35jiRuLcq4OEFpQUEKdLSuLQgdDn2QBSqmKlmL3Lg92kOTRoZEZURL2QCzHjGLkLrh6 6BI9lKk6vb1ZrPxXJ+pQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSnNJ-00016p-7h; Thu, 07 Nov 2019 19:23:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSnNG-00016H-P2 for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 19:23:20 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3E31B2084C; Thu, 7 Nov 2019 19:23:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573154598; bh=ftSd/7ehpdn2j3hx+l5leGMaV+fCv0vWroHDpGfHRto=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=0hfQhQvlAHgZvgSiYj3SqZoxBDYPhBwxS6V8lIJkE4gCKLNVwr8xFW/VnOTg57eas U5E6mrzmitJwEZL+uDSfwiAvFlvQcY6Fb59c8wJ2ZggGWcAqQMi/X77ePluNmW6djh BeIajKROeKq22+QdH6HG0wwx9TC+ayGA5ru8WZoU= MIME-Version: 1.0 In-Reply-To: <1573120694-6015-1-git-send-email-rajan.vaja@xilinx.com> References: <1573120694-6015-1-git-send-email-rajan.vaja@xilinx.com> From: Stephen Boyd To: Rajan Vaja , jolly.shah@xilinx.com, michal.simek@xilinx.com, mturquette@baylibre.com, nava.manne@xilinx.com, shubhrajyoti.datta@xilinx.com, tejas.patel@xilinx.com Subject: Re: [PATCH] clk: zynqmp: Warn user if clock user are more than allowed User-Agent: alot/0.8.1 Date: Thu, 07 Nov 2019 11:23:17 -0800 Message-Id: <20191107192318.3E31B2084C@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_112318_834984_ACDB5772 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rajan Vaja , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Rajan Vaja (2019-11-07 01:58:14) > Warn user if clock is used by more than allowed devices. > This check is done by firmware and returns respective > error code. Upon receiving error code for excessive user, > warn user for the same. > > This change is done to restrict VPLL use count. It is > assumed that VPLL is used by one user only. > > Signed-off-by: Rajan Vaja > Signed-off-by: Michal Simek This sign off chain is incorrect. > --- > drivers/clk/zynqmp/pll.c | 9 ++++++--- > drivers/firmware/xilinx/zynqmp.c | 2 ++ > include/linux/firmware/xlnx-zynqmp.h | 1 + > 3 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/zynqmp/pll.c b/drivers/clk/zynqmp/pll.c > index a541397..2f4ccaa 100644 > --- a/drivers/clk/zynqmp/pll.c > +++ b/drivers/clk/zynqmp/pll.c > @@ -188,9 +188,12 @@ static int zynqmp_pll_set_rate(struct clk_hw *hw, unsigned long rate, > frac = (parent_rate * f) / FRAC_DIV; > > ret = eemi_ops->clock_setdivider(clk_id, m); > - if (ret) > - pr_warn_once("%s() set divider failed for %s, ret = %d\n", > - __func__, clk_name, ret); > + if (ret) { > + if (ret == -EUSERS) > + WARN(1, "More than allowed devices are using the %s, which is forbidden\n", clk_name); > + pr_err("%s() set divider failed for %s, ret = %d\n", > + __func__, clk_name, ret); > + } Shouldn't we catch this much earlier when clk_get() is called or something like that? > > eemi_ops->ioctl(0, IOCTL_SET_PLL_FRAC_DATA, clk_id, f, NULL); > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 75bdfaa..74d9f13 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -48,6 +48,8 @@ static int zynqmp_pm_ret_code(u32 ret_status) > return -EACCES; > case XST_PM_ABORT_SUSPEND: > return -ECANCELED; > + case XST_PM_MULT_USER: > + return -EUSERS; This is for filesystem quotas? It's a weird error return value. > case XST_PM_INTERNAL: > case XST_PM_CONFLICT: > case XST_PM_INVALID_NODE: _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel