From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87864C43331 for ; Thu, 7 Nov 2019 23:39:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2649C21882 for ; Thu, 7 Nov 2019 23:39:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tdbV3h3H"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="HmhgVhLY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2649C21882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SNftxZmti5mmojI4/oOlWiBcuIl3m0p6uD1z+3XQjbU=; b=tdbV3h3HBPu9kc Bjvr53uEgP+D3VlJYe6D+idGAqbYSFy5lYapRVQjWYHI/e6GvXn7iAbxyN2qalZ+hqs5bWaYESq7I teLdTUUjSmJJODPp3JJd5xd6OJjTrGRYWUM8+Sc8pIl+GxEMaowakKvpeaZauoNJPRwY0pw/lBGh3 nzWMZUkQRv3RfbxY0zuYNZmukY7D/O0OrUDT+IpPEYVUUVo/0oXGzQU6Xvc8dY2jA25284yu5P0UY fBcXd+jXpg4cl2kpFNGajaIHyJpeQvg/DwhZaVKhyen6vKGm5dxRZjFIsVwBliCtDkVEtfjSzWr6k osTVr3TUdnqTYFt4FiCA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSrNd-0006HD-JD; Thu, 07 Nov 2019 23:39:57 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iSrNa-0006G6-D9 for linux-arm-kernel@lists.infradead.org; Thu, 07 Nov 2019 23:39:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1qs3twHrOv8/gUtMmC9w6XFHjj/oevpNdMaw8wOsiFs=; b=HmhgVhLYU5zOEYAsJyAWNV36y qtTI1yT+j4t0goRi19K2HC9r/j7qFLN5Yd9Z06xCTd7nYkf9QuD+f3mDY5Zo6o3kLFr/440S5v+YX VpDoyLub0gM0XtTv1Ta4bGPWIJqrFYhGqnYe/qFPnk/6ViWCPh9mNOFR9JFl78fXF9slInV08y2aW SvVj3uGMwsgyoXuFwshkdXHwXQ8QgEpWwYyfTkZCTKBXHNGmn8HyQgWvcdrWaaqn41sWrOu2aiN9/ YUKIZMoyoU2ER4/xYUqckW3JnuEtT/YRKkVwTil2PoMKPKCP5vdZkmqMJQN29lImcz3IP1dJDo/OM dXYUkrTfw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36606) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iSrN4-0006Zz-HV; Thu, 07 Nov 2019 23:39:22 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1iSrMw-0005P4-BS; Thu, 07 Nov 2019 23:39:14 +0000 Date: Thu, 7 Nov 2019 23:39:14 +0000 From: Russell King - ARM Linux admin To: Rikard Falkeborn Subject: Re: [PATCH] phy: allwinner: Fix GENMASK misuse Message-ID: <20191107233914.GW25745@shell.armlinux.org.uk> References: <20191020134229.1216351-3-megous@megous.com> <20191107204645.13739-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191107204645.13739-1-rikard.falkeborn@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191107_153954_443892_BBBB0B65 X-CRM114-Status: UNSURE ( 9.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: megous@megous.com, mark.rutland@arm.com, arnd@arndb.de, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, mripard@kernel.org, kishon@ti.com, paul.kocialkowski@bootlin.com, linux-sunxi@googlegroups.com, robh+dt@kernel.org, tglx@linutronix.de, wens@csie.org, linux-arm-kernel@lists.infradead.org, icenowy@aosc.io Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Nov 07, 2019 at 09:46:45PM +0100, Rikard Falkeborn wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Rikard Falkeborn > --- > Spotted while trying to add compile time checks of GENMASK arguments. > Patch has only been compile tested. My feeling, personally, is that GENMASK() really isn't worth the pain it causes. Can we instead get rid of this thing and just use easier to understand and less error-prone hex masks please? I don't care what anyone else says, personally I'm going to stick with using hex masks as I find them way easier to get right first time than a problematical opaque macro - and I really don't want the effort of finding out that I've got the arguments wrong when I build it. It's just _way_ easier and less error prone to use a hex mask straight off. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel