From: Mark Brown <broonie@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: kaslr: Print warning if KASLR is disabled due to lack of seed
Date: Fri, 8 Nov 2019 14:35:54 +0000 [thread overview]
Message-ID: <20191108143554.GF5532@sirena.co.uk> (raw)
In-Reply-To: <20191108141426.GC11465@lakrids.cambridge.arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 913 bytes --]
On Fri, Nov 08, 2019 at 02:14:27PM +0000, Mark Rutland wrote:
> To avoid surprises, I think it'd be best to log that state later, in
I was just going to add an initcall in kaslr.c to keep things together.
> setup.c. We can also do that consistently, so that the user has a
> positive message when KASLR is in use.
So long as people are happy announcing it, I didn't add anything since I
wasn't clear if this was a deliberate decision to not provide
information but I see now it was more likely just the fact that it's
running too early to reliably print.
> enum kaslr_status {
> KASLR_ENABLED,
> KASLR_DISABLED,
> KASLR_NO_SEED,
> };
> enum kaslr_status __ro_after_init kaslr_status;
> ... and switch on that in setup.c.
Having the enum seems like it spreads the code out for unclear
advantage, apart from the logging nothing particularly cares about
anything other than the enabled/disabled decision.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-08 14:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 12:12 [PATCH] arm64: kaslr: Print warning if KASLR is disabled due to lack of seed Mark Brown
2019-11-08 13:38 ` Catalin Marinas
2019-11-08 14:14 ` Mark Rutland
2019-11-08 14:35 ` Mark Brown [this message]
2019-11-08 14:17 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108143554.GF5532@sirena.co.uk \
--to=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).