From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25779FC6195 for ; Fri, 8 Nov 2019 15:50:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0264215EA for ; Fri, 8 Nov 2019 15:50:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JKHv27aS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="EwxxEP7m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0264215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YeUYDv9PDmn+/Gi544JA4Yg3KJl7S3i+6xqCj2cGbA0=; b=JKHv27aSX0pnOO/7JugV8zGia ZJtGwb6WL6MeRaRPrsqrj8Wl5OVUDD1MTNtUhZBkK4aqr/5VYLJvLMsE4hyE7JycQtA/qC3786GSB xOjCUSyQxuCISO/QvP5q+4G7OGdMzT3GYktDsnEo23nS15ZLtUcNmh3Rdh3LXMXPISfW0TrkPn8K6 XvhRuulEaamkkMXXIAeYQJTRfGLotbqymQdYw64QSib4x8oXkBHjuB4BRFmJN2ILGLHYu+3ldT5A7 bivQu+h2VjwzQgTzpqmeh3PcV6e9Rl4M30ZIF/NpILskElwDeAJ9RLomVuPhZybxa+Qd1ERruu3zD r6uKYYwyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT6WZ-0008Oi-9u; Fri, 08 Nov 2019 15:50:11 +0000 Received: from heliosphere.sirena.org.uk ([172.104.155.198]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT6WV-00082v-Nk for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 15:50:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=O+7LzaPKtzUuL0hkLWx0Mi5/035wwUrxS/yxkQE7h9s=; b=EwxxEP7mUit1N7SsiMow5eIAI tNDJ62QlB8H37c1pfXewDMitRCBUDhAcnMgENtJ9MiphWC2G+9X28ZD7f0EFODwJ83eEnt9R8ZpGJ Gt1qFxvCLkYzDI575lKG0AsZsIC9ce2AQBnSOX54wX9fCosUEOspXbJCitIAQhK+VLNk4=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iT6WT-0007ZM-TB; Fri, 08 Nov 2019 15:50:05 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 578F02741450; Fri, 8 Nov 2019 15:50:05 +0000 (GMT) Date: Fri, 8 Nov 2019 15:50:05 +0000 From: Mark Brown To: Catalin Marinas , Will Deacon , Mark Rutland Subject: Re: [PATCH v2 2/2] arm64: kaslr: Check command line before looking for a seed Message-ID: <20191108155005.GG5532@sirena.co.uk> References: <20191108154607.51051-1-broonie@kernel.org> <20191108154607.51051-3-broonie@kernel.org> MIME-Version: 1.0 In-Reply-To: <20191108154607.51051-3-broonie@kernel.org> X-Cookie: Life is like a simile. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_075007_786869_5D7B1248 X-CRM114-Status: UNSURE ( 9.84 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============6937841411133037219==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6937841411133037219== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="eMnpOGXCMazMAbfp" Content-Disposition: inline --eMnpOGXCMazMAbfp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 08, 2019 at 03:46:07PM +0000, Mark Brown wrote: > - /* > - * Retrieve (and wipe) the seed from the FDT > - */ > - seed = get_kaslr_seed(fdt); > - if (!seed) { > - kaslr_status = KASLR_DISABLED_NO_SEED; > - return 0; > - } > - Sorry, realized immediately after sending this that it would be better to only move the if statement here in case the user has provided a seed but also explicitly disabled KASLR. --eMnpOGXCMazMAbfp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3FjqwACgkQJNaLcl1U h9CAGwf+J/JBiEs4gZlnVyKnDyijyC8gq4SFVMPzo6HMFwamMpCeu6uV9FDjQ9n4 oV7/rQgEo4gEhystWW7Au/ARjaro4p5tuTtdvaonSlUVzqJqoZ08UmnAcgVnwReu oYk4y5KnQoUSBq0Ob7P7gmzr/vd9JQORVtTqelU/xu4y5nvSluMG19KvTbszLW4y yMInt9NG5MHliXFOspNfVVrNtinxdb0kdoW4rWzfmGq4SbDlFQsTswJJvT4ukJK2 beSPlY901Qd1cIyX6IcqswQClfyd/AAFzAIV6dQ5qtdWy1HMyPYfqdCKdtb0ivqV L/pcKYJeRq4wjcep7gPwu2gPkgr4Zw== =z5qn -----END PGP SIGNATURE----- --eMnpOGXCMazMAbfp-- --===============6937841411133037219== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6937841411133037219==--