From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFCEFC6196 for ; Fri, 8 Nov 2019 21:59:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6826F215EA for ; Fri, 8 Nov 2019 21:59:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ACarJ1tY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="wGrrx/iw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6826F215EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R39vSfxD154mbGJyfjoJb2wfKAbgO5Pd4gU71rBYRUo=; b=ACarJ1tYXGIw/2 9Gynyuwyb7T59wI9RsAK7ZLBlSmR/KD21L7Znu8twoj3vbDHucJQ6n60fwAHdywFdsaO0AJnHPg2b dLsj8JYRJ6QnTXzopC3ne4MMNPF01LmHPBL0In2mLnYWKR18ecc6QSf3CwzsFISGZLnuC5bqrMmHN HmE7Wtr7gIJTzzV17sxow9yTNCZedWV1E3RbtjGjLaxlSL9xUX5QECW0o5ZIYJs5GfQvLWFMYRShM KQvz+05tQVnzlDAucRvuuIkZVEizhD4W3hI7xpjJZQ/1MzYV0eV1ai1SAKlEHgr0+2I50X2WH3LWU TyyTX8blr3romUnmtPWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTCI4-0000ET-JK; Fri, 08 Nov 2019 21:59:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iTCI2-0000DY-Kq for linux-arm-kernel@lists.infradead.org; Fri, 08 Nov 2019 21:59:35 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 04116215EA; Fri, 8 Nov 2019 21:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573250372; bh=7mrqfpImF3WKKRtg7Ezmmz1CFh2d+r8Qd4+2OG2Tczo=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=wGrrx/iwplMLeV29MugYEr2LUO4l7l3cWULndDiGaCR8UHZeHvoWdneicZZ+CU57P JFMuwVSvzVO7iNqxb3KYc+Ya3kMZC1QeA226qiJBxrz5nEKjQje/RrrVfiiKhj/fGx /foc8jkSqzVIY3P3dbJHmlbllYV/M/aHNkL+4KxQ= MIME-Version: 1.0 In-Reply-To: <87tv7qm0ck.fsf@belgarion.home> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-35-arnd@arndb.de> <20191028092327.939C82184C@mail.kernel.org> <87tv7qm0ck.fsf@belgarion.home> From: Stephen Boyd To: Robert Jarzmik Subject: Re: [PATCH 35/46] cpufreq: pxa3: move clk register access to clk driver User-Agent: alot/0.8.1 Date: Fri, 08 Nov 2019 13:59:31 -0800 Message-Id: <20191108215932.04116215EA@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191108_135934_702907_351DA1A4 X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , linux-pm@vger.kernel.org, Viresh Kumar , Linus Walleij , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, Haojian Zhuang , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Robert Jarzmik (2019-10-30 13:42:35) > Stephen Boyd writes: > > > Quoting Arnd Bergmann (2019-10-18 08:41:50) > >> +void pxa3xx_clk_update_accr(u32 disable, u32 enable, u32 xclkcfg, u32 mask) > >> +{ > >> + u32 accr = ACCR; > >> + > >> + accr &= ~disable; > >> + accr |= enable; > >> + > >> + ACCR = accr; > >> + if (xclkcfg) > >> + __asm__("mcr p14, 0, %0, c6, c0, 0\n" : : "r"(xclkcfg)); > > > > It's just a coprocessor instruction though? I don't see what this has to > > do with clks that we model in the kernel? Why can't it just be put in > > the cpufreq driver that calls it? > I think you forget the "ACCR = accr", which is an MMIO register write. ACCR > stands for "Application Subsystem Clock Configuration Register", so I think Arnd > is right to put it in here. > > As for the broader question you ask, about the cpufreq driver, the reason is > unfortunately "historic" : pxa3xx cpufreq driver doesn't use the clock framework > to set the bus clocks, but does it by directly accessing the registers : old > platform, old ways, etc ... > Ah ok. I missed the writel at the end of the function. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel