On Mon, Nov 11, 2019 at 02:22:33PM +0000, Suzuki K Poulose wrote:
> On 08/11/2019 17:01, Mark Brown wrote:

> > +	/*
> > +	 * The cpu_enable() callback gets called even on CPUs that
> > +	 * don't detect the feature so we need to verify if we can
> > +	 * enable.
> > +	 */
> > +	if (this_cpu_has_cap(ARM64_HAS_E0PD))
> > +		sysreg_clear_set(tcr_el1, 0, TCR_E0PD1);

> As mentioned in the previous version, this could set a superfluous model
> for people to do the same check for future SYSTEM_FEATURE type capabilities.
> I leave it to the maintainers.

To also reiterate the check doesn't hurt anything and avoids the
potential for future breakage if the capability gets changed (which
would be good to do).