From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D5A0C43331 for ; Mon, 11 Nov 2019 18:32:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35A54222C1 for ; Mon, 11 Nov 2019 18:32:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HGNTkMOM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35A54222C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p7pJBL34zOPy74j4NW+wbl8MaIbit08+s5e4/k4IKzE=; b=HGNTkMOMyuj5Ag pBSv6jym5s83TaJ+p3vTFqLoSZift8lUdqjzpX/4wBVuytOP3Vd4S3nOIEIaLE1dfRFJa4VLzwn5z Ga0bMe+RTmc5pIDZS6Jv0w6Kpc3ABcXATs+LmEiQJeBIpubisSD3s63TqDrwFe/V9eU07XF4J9t34 rxdCEJ2x0OQP8RIIcMV54s3nmlAPTsr3w9SPyKzUoXYWirfXyvoem4LyDDSUFeqK+B2AdofCFglFE 9mcsQbaW59N75zMsthXwQ5ARXWVNVojhBRoOU7LDztP3350XTfdLpXVux9pFAjuryEx8MkPsG4aMh gUhslZ7yiAOQRF420dqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUETm-00008E-3Y; Mon, 11 Nov 2019 18:31:58 +0000 Received: from mx2.suse.de ([195.135.220.15] helo=mx1.suse.de) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUETj-000078-KP for linux-arm-kernel@lists.infradead.org; Mon, 11 Nov 2019 18:31:57 +0000 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 14E12B2E3; Mon, 11 Nov 2019 18:31:54 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 48398DA7AF; Mon, 11 Nov 2019 19:31:58 +0100 (CET) Date: Mon, 11 Nov 2019 19:31:58 +0100 From: David Sterba To: Andreas =?iso-8859-1?Q?F=E4rber?= Subject: Re: [PATCH next 1/2] btrfs: tree-checker: Fix error format string Message-ID: <20191111183158.GT3001@twin.jikos.cz> Mail-Followup-To: dsterba@suse.cz, Andreas =?iso-8859-1?Q?F=E4rber?= , Qu Wenruo , David Sterba , Johannes Thumshirn , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20191108213853.16635-1-afaerber@suse.de> <20191108213853.16635-2-afaerber@suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191108213853.16635-2-afaerber@suse.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_103155_813815_FAD24F43 X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: dsterba@suse.cz Cc: linux-arm-kernel@lists.infradead.org, Josef Bacik , linux-kernel@vger.kernel.org, Chris Mason , Qu Wenruo , Johannes Thumshirn , David Sterba , linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 08, 2019 at 10:38:52PM +0100, Andreas F=E4rber wrote: > From: Andreas F=E4rber > = > Argument BTRFS_FILE_EXTENT_INLINE_DATA_START is defined as offsetof(), > which returns type size_t, so we need %zu instead of %lu. > = > This fixes a build warning on 32-bit arm: > = > ../fs/btrfs/tree-checker.c: In function 'check_extent_data_item': > ../fs/btrfs/tree-checker.c:230:43: warning: format '%lu' expects argume= nt of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wf= ormat=3D] > 230 | "invalid item size, have %u expect [%lu, %u)", > | ~~^ > | | > | long unsigned int > | %u Is there a gcc warning option that can catch that on 64bit too? -Wformat=3D2 does not and I don't see any other of the option family to do that. We've had fixups of the size_t printk formats and I'd like to catch that when the patches are added to the devel branches. I can't run 32bit build check each time but this seems to be the only way so far. > Fixes: a31ccb4b7ba2 ("btrfs: tree-checker: Check item size before reading= file extent type") As the patch is still in the devel branch, the commit id is not stable and I'll fold the change to to the patch. Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel