Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kever Yang <kever.yang@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, heiko@sntech.de,
	daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Ezequiel Garcia <ezequiel@collabora.com>,
	linux-arm-kernel@lists.infradead.org,
	Akash Gajjar <akash@openedev.com>
Subject: Re: [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log
Date: Wed, 13 Nov 2019 08:51:41 +0530
Message-ID: <20191113032141.GB3377@Mani-XPS-13-9360> (raw)
In-Reply-To: <885996a6-e314-52c8-fec4-f66526dd1397@rock-chips.com>

Hi Kever,

On Wed, Nov 13, 2019 at 10:44:02AM +0800, Kever Yang wrote:
> Hi Manivannan,
> 
> On 2019/11/13 上午1:17, Manivannan Sadhasivam wrote:
> > On Tue, Nov 12, 2019 at 04:10:17PM +0800, Kever Yang wrote:
> > > On 2019/11/11 下午1:22, Manivannan Sadhasivam wrote:
> > > > Hi Kever,
> > > > 
> > > > On Mon, Nov 11, 2019 at 08:51:57AM +0800, Kever Yang wrote:
> > > > > Add vdd_log node according to rock960 schematic V13.
> > > > > 
> > > > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> > > > > ---
> > > > > 
> > > > >    arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 12 ++++++++++++
> > > > >    1 file changed, 12 insertions(+)
> > > > > 
> > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > > > index c7d48d41e184..73afee257115 100644
> > > > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > > > @@ -76,6 +76,18 @@
> > > > >    		regulator-always-on;
> > > > >    		vin-supply = <&vcc5v0_sys>;
> > > > >    	};
> > > > > +
> > > > > +	vdd_log: vdd-log {
> > > > > +		compatible = "pwm-regulator";
> > > > > +		pwms = <&pwm2 0 25000 1>;
> > > > > +		regulator-name = "vdd_log";
> > > > > +		regulator-always-on;
> > > > > +		regulator-boot-on;
> > > > > +		regulator-min-microvolt = <800000>;
> > > > > +		regulator-max-microvolt = <1400000>;
> > > > > +		regulator-init-microvolt = <950000>;
> > > > The default value seems to be 0.9v as per both Rock960 and Ficus schematics.
> > > 
> > > The default value is 0.9V when pwm-regulator is not enabled, and this
> > > 'init-microvolt' suppose to set the
> > > 
> > > init value when pwm-regulator is enabled. I set this to 950mV because Peter
> > > report that he experience
> > > 
> > > the system hang during Fedora boot  up, and update the vdd_log to 950mV can
> > > fix the issue due to
> > > 
> > > engineer measure on another rk3399 board puma-Q7.
> > > 
> > okay. Previously we had post-boot hang issue on Rock960 Model A boards when the
> > performance governor was set as default. So the vdd_log node was removed from
> > the devicetree. Have you tested that case also?
> > 
> > Here is the commit:
> > 13682e524167 ("arm64: dts: rockchip: remove vdd_log from rock960 to fix a stability issues")
> 
> 
> For rk3399, the kernel does not touch this regulator, it should be take care
> by bootloader.
> 
> So I think we need to update both U-Boot and kernel.
> 

Hmm, okay. I will try to test these patches soon and share the observation here.

Thanks,
Mani

> 
> Thanks,
> 
> - Kever
> 
> > 
> > thanks,
> > Mani
> > > Thanks,
> > > 
> > > - Kever
> > > 
> > > > Other than that,
> > > > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > > > 
> > > > Thanks,
> > > > Mani
> > > > 
> > > > > +		vin-supply = <&vcc_sys>;
> > > > > +	};
> > > > >    };
> > > > >    &cpu_l0 {
> > > > > -- 
> > > > > 2.17.1
> > > > > 
> > > 
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply index

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  0:51 [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Kever Yang
2019-11-11  0:51 ` [PATCH 2/3] arm64: dts: rk3399-rock960: add vdd_log Kever Yang
2019-11-11  5:22   ` Manivannan Sadhasivam
2019-11-11  5:26     ` Manivannan Sadhasivam
2019-11-12  8:10     ` Kever Yang
2019-11-12 17:17       ` Manivannan Sadhasivam
2019-11-13  2:44         ` Kever Yang
2019-11-13  3:21           ` Manivannan Sadhasivam [this message]
2019-11-11  0:51 ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Kever Yang
2019-11-11  8:42   ` Soeren Moch
2019-11-12  8:04     ` Kever Yang
2019-11-12  8:10       ` Heiko Stübner
2019-11-13  3:21         ` Kever Yang
2019-11-18  1:05           ` Heiko Stuebner
2019-11-12  8:16       ` Markus Reichl
2019-11-12  8:44         ` Sören Moch
2019-11-12  8:51           ` Markus Reichl
2019-11-12 10:02         ` Kever Yang
2019-11-12 10:19           ` Soeren Moch
2019-11-12 11:06             ` Markus Reichl
2019-11-12 11:42             ` [PATCH] arm64: dts: rockchip: Fix vdd_log on rk3399-roc-pc Markus Reichl
2019-11-18  1:03               ` Heiko Stuebner
2019-11-13 17:01   ` [PATCH 3/3] arm64: dts: rk3399: Add init voltage for vdd_log Doug Anderson
2019-11-14  1:53     ` Kever Yang
2019-11-13 17:50   ` Vicente Bergas
2019-11-18  1:04 ` [PATCH 1/3] arm64: dts: rockchip: Fix min voltage for rk3399-firefly vdd_log Heiko Stuebner

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191113032141.GB3377@Mani-XPS-13-9360 \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=akash@openedev.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=jagan@amarulasolutions.com \
    --cc=kever.yang@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git