From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-pwm@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Maxime Ripard <mripard@kernel.org>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Thierry Reding <thierry.reding@gmail.com>,
Philipp Zabel <pza@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 5/7] pwm: sun4i: Add support for H6 PWM
Date: Wed, 13 Nov 2019 10:00:11 +0100 [thread overview]
Message-ID: <20191113090011.7io7stqtovtsaia6@pengutronix.de> (raw)
In-Reply-To: <20191108084517.21617-6-peron.clem@gmail.com>
On Fri, Nov 08, 2019 at 09:45:15AM +0100, Clément Péron wrote:
> From: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Now that sun4i PWM driver supports deasserting reset line and enabling
> bus clock, support for H6 PWM can be added.
>
> Note that while H6 PWM has two channels, only first one is wired to
> output pin. Second channel is used as a clock source to companion AC200
> chip which is bundled into same package.
>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Very minor nitpick: The order here is wrong, your S-o-b should be the
last thing here.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-13 9:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 8:45 [PATCH v4 0/7] Add support for H6 PWM Clément Péron
2019-11-08 8:45 ` [PATCH v4 1/7] dt-bindings: pwm: allwinner: Add H6 PWM description Clément Péron
2019-11-12 19:31 ` Rob Herring
2019-11-08 8:45 ` [PATCH v4 2/7] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-13 8:27 ` Uwe Kleine-König
2019-11-08 8:45 ` [PATCH v4 3/7] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-13 8:35 ` Uwe Kleine-König
2019-11-14 22:36 ` Clément Péron
2019-11-15 7:25 ` Uwe Kleine-König
2019-11-08 8:45 ` [PATCH v4 4/7] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-13 8:58 ` Uwe Kleine-König
2019-11-14 22:47 ` Clément Péron
2019-11-15 7:35 ` Uwe Kleine-König
2019-11-08 8:45 ` [PATCH v4 5/7] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-13 9:00 ` Uwe Kleine-König [this message]
2019-11-08 8:45 ` [PATCH v4 6/7] arm64: dts: allwinner: h6: Add PWM node Clément Péron
2019-11-08 8:45 ` [PATCH v4 7/7] [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113090011.7io7stqtovtsaia6@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=pza@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).