linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ARM: dts: ux500: Add pin configs for UART1 CTS/RTS pins
Date: Mon, 25 Nov 2019 15:17:40 +0100	[thread overview]
Message-ID: <20191125141740.GA55734@gerhold.net> (raw)
In-Reply-To: <20191125122256.53482-4-stephan@gerhold.net>

On Mon, Nov 25, 2019 at 01:22:55PM +0100, Stephan Gerhold wrote:
> UART1 an be optionally used with additional CTS/RTS pins.

s/an/can, duh.
I will fix this if a v2 is needed for some reason; otherwise,
can you fix this when applying the patch?

Thanks!

> The pinctrl driver has an extra "u1ctsrts_a_1" pin group for them.
> 
> Add a new pin configuration to configure them correctly if needed.
> 
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  arch/arm/boot/dts/ste-dbx5x0-pinctrl.dtsi | 26 +++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ste-dbx5x0-pinctrl.dtsi b/arch/arm/boot/dts/ste-dbx5x0-pinctrl.dtsi
> index b6d0a60e9aed..e85a08ad2ea7 100644
> --- a/arch/arm/boot/dts/ste-dbx5x0-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/ste-dbx5x0-pinctrl.dtsi
> @@ -65,6 +65,32 @@
>  				ste,config = <&slpm_out_wkup_pdis>;
>  			};
>  		};
> +
> +		u1ctsrts_a_1_default: u1ctsrts_a_1_default {
> +			default_mux {
> +				function = "u1";
> +				groups = "u1ctsrts_a_1";
> +			};
> +			default_cfg1 {
> +				pins = "GPIO6_AF6"; /* CTS */
> +				ste,config = <&in_pu>;
> +			};
> +			default_cfg2 {
> +				pins = "GPIO7_AG5"; /* RTS */
> +				ste,config = <&out_hi>;
> +			};
> +		};
> +
> +		u1ctsrts_a_1_sleep: u1ctsrts_a_1_sleep {
> +			sleep_cfg1 {
> +				pins = "GPIO6_AF6"; /* CTS */
> +				ste,config = <&slpm_in_wkup_pdis>;
> +			};
> +			sleep_cfg2 {
> +				pins = "GPIO7_AG5"; /* RTS */
> +				ste,config = <&slpm_out_hi_wkup_pdis>;
> +			};
> +		};
>  	};
>  
>  	uart2 {
> -- 
> 2.24.0
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-11-25 14:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 12:22 [PATCH 1/5] ARM: dts: ux500: Move generic pin configs out of ste-href-family-pinctrl.dtsi Stephan Gerhold
2019-11-25 12:22 ` [PATCH 2/5] ARM: dts: ux500: Rename generic pin configs according to pin group Stephan Gerhold
2019-11-25 15:37   ` Linus Walleij
2019-11-25 12:22 ` [PATCH 3/5] ARM: dts: ux500: Add alternative SDI pin configs Stephan Gerhold
2019-11-25 15:38   ` Linus Walleij
2019-11-25 12:22 ` [PATCH 4/5] ARM: dts: ux500: Add pin configs for UART1 CTS/RTS pins Stephan Gerhold
2019-11-25 14:17   ` Stephan Gerhold [this message]
2019-11-25 15:40   ` Linus Walleij
2019-11-25 12:22 ` [PATCH 5/5] ARM: dts: ux500: nomadik-pinctrl: Add &gpio_in_nopull Stephan Gerhold
2019-11-25 15:35 ` [PATCH 1/5] ARM: dts: ux500: Move generic pin configs out of ste-href-family-pinctrl.dtsi Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125141740.GA55734@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=devicetree@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).