linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/3] arm64: dts: allwinner: a64: olinuxino: Update regulators
@ 2019-11-29 11:39 Stefan Mavrodiev
  2019-11-29 11:39 ` [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator Stefan Mavrodiev
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Stefan Mavrodiev @ 2019-11-29 11:39 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	moderated list:ARM/Allwinner sunXi SoC support,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: linux-sunxi, Stefan Mavrodiev

This patch serie updates bank regulators for A64-OLinuXino and 
A64-OLinuXino-eMMC.

Also, eMMC supply is changed to ELDO1, which is the actual one. The same is
done for the SDIO card - ALDO2 is changed to DCDC1.

Changes for v2:
 - Restore the original eMMC vmmc-supply property
 - Add fixes and kernel tags

Stefan Mavrodiev (3):
  arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
  arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
  arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator

 .../allwinner/sun50i-a64-olinuxino-emmc.dts    |  6 +++++-
 .../dts/allwinner/sun50i-a64-olinuxino.dts     | 18 +++++++++++++++++-
 2 files changed, 22 insertions(+), 2 deletions(-)

-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
  2019-11-29 11:39 [PATCH v2 0/3] arm64: dts: allwinner: a64: olinuxino: Update regulators Stefan Mavrodiev
@ 2019-11-29 11:39 ` Stefan Mavrodiev
  2019-12-02 19:13   ` Maxime Ripard
  2019-11-29 11:39 ` [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators Stefan Mavrodiev
  2019-11-29 11:39 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator Stefan Mavrodiev
  2 siblings, 1 reply; 7+ messages in thread
From: Stefan Mavrodiev @ 2019-11-29 11:39 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	moderated list:ARM/Allwinner sunXi SoC support,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: linux-sunxi, stable, Stefan Mavrodiev

A64-OLinuXino-eMMC uses 1.8V for eMMC supply. This is done via a triple
jumper, which sets VCC-PL to either 1.8V or 3.3V. This setting is different
for boards with and without eMMC.

This is not a big issue for DDR52 mode, however the eMMC will not work in
HS200/HS400, since these modes explicitly requires 1.8V.

Fixes: 94f68f3a4b2a ("arm64: dts: allwinner: a64: Add A64 OlinuXino board (with eMMC)")
Cc: stable@vger.kernel.org # v5.4
Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
---
Changes for v2:
 - Restore the original eMMC vmmc-supply property

 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
index 96ab0227e82d..121e6cc4849b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
@@ -15,7 +15,7 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc2_pins>;
 	vmmc-supply = <&reg_dcdc1>;
-	vqmmc-supply = <&reg_dcdc1>;
+	vqmmc-supply = <&reg_eldo1>;
 	bus-width = <8>;
 	non-removable;
 	cap-mmc-hw-reset;
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
  2019-11-29 11:39 [PATCH v2 0/3] arm64: dts: allwinner: a64: olinuxino: Update regulators Stefan Mavrodiev
  2019-11-29 11:39 ` [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator Stefan Mavrodiev
@ 2019-11-29 11:39 ` Stefan Mavrodiev
  2019-12-02 19:16   ` Maxime Ripard
  2019-11-29 11:39 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator Stefan Mavrodiev
  2 siblings, 1 reply; 7+ messages in thread
From: Stefan Mavrodiev @ 2019-11-29 11:39 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	moderated list:ARM/Allwinner sunXi SoC support,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: linux-sunxi, Stefan Mavrodiev

Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This
patch adds regulators for them to the pinctrl node.

Exception is PL which is used by the RSB bus. To avoid circular
dependencies, VCC-PL is omitted.

On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.

Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
---
 .../dts/allwinner/sun50i-a64-olinuxino-emmc.dts  |  4 ++++
 .../boot/dts/allwinner/sun50i-a64-olinuxino.dts  | 16 ++++++++++++++++
 2 files changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
index 121e6cc4849b..12f8c62c4f52 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino-emmc.dts
@@ -21,3 +21,7 @@
 	cap-mmc-hw-reset;
 	status = "okay";
 };
+
+&pio {
+	vcc-pc-supply = <&reg_eldo1>;
+};
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index 01a9a52edae4..ad3559c576dd 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -163,6 +163,22 @@
 	status = "okay";
 };
 
+&pio {
+	vcc-pc-supply = <&reg_dcdc1>;
+	vcc-pd-supply = <&reg_dcdc1>;
+	vcc-pe-supply = <&reg_aldo1>;
+	vcc-pg-supply = <&reg_dldo4>;
+};
+
+&r_pio {
+	/**
+	 * Do not add vcc-pl-supply, since PL0 and PL1 are used
+	 * by the RSB bus.
+	 *
+	 * vcc-pl-supply = <&reg_aldo2>;
+	 */
+};
+
 &r_rsb {
 	status = "okay";
 
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator
  2019-11-29 11:39 [PATCH v2 0/3] arm64: dts: allwinner: a64: olinuxino: Update regulators Stefan Mavrodiev
  2019-11-29 11:39 ` [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator Stefan Mavrodiev
  2019-11-29 11:39 ` [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators Stefan Mavrodiev
@ 2019-11-29 11:39 ` Stefan Mavrodiev
  2019-12-02 19:17   ` Maxime Ripard
  2 siblings, 1 reply; 7+ messages in thread
From: Stefan Mavrodiev @ 2019-11-29 11:39 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai, Rob Herring, Mark Rutland,
	moderated list:ARM/Allwinner sunXi SoC support,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: linux-sunxi, stable, Stefan Mavrodiev

A64-OLinuXino uses DCDC1 (VCC-IO) for MMC1 supply. In commit 916b68cfe4b5
("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi") ALDO2 is set, which is
VCC-PL. Since DCDC1 is always present, the boards are working without a
problem.

This patch sets the correct regulator.

Fixes: 916b68cfe4b5 ("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi")
Cc: stable@vger.kernel.org # v4.16+
Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
index ad3559c576dd..869bb146a9ff 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-olinuxino.dts
@@ -140,7 +140,7 @@
 &mmc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&mmc1_pins>;
-	vmmc-supply = <&reg_aldo2>;
+	vmmc-supply = <&reg_dcdc1>;
 	vqmmc-supply = <&reg_dldo4>;
 	mmc-pwrseq = <&wifi_pwrseq>;
 	bus-width = <4>;
-- 
2.17.1

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator
  2019-11-29 11:39 ` [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator Stefan Mavrodiev
@ 2019-12-02 19:13   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2019-12-02 19:13 UTC (permalink / raw)
  To: Stefan Mavrodiev
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-sunxi, open list, stable, Chen-Yu Tsai, Rob Herring,
	moderated list:ARM/Allwinner sunXi SoC support


[-- Attachment #1.1: Type: text/plain, Size: 598 bytes --]

On Fri, Nov 29, 2019 at 01:39:39PM +0200, Stefan Mavrodiev wrote:
> A64-OLinuXino-eMMC uses 1.8V for eMMC supply. This is done via a triple
> jumper, which sets VCC-PL to either 1.8V or 3.3V. This setting is different
> for boards with and without eMMC.
>
> This is not a big issue for DDR52 mode, however the eMMC will not work in
> HS200/HS400, since these modes explicitly requires 1.8V.
>
> Fixes: 94f68f3a4b2a ("arm64: dts: allwinner: a64: Add A64 OlinuXino board (with eMMC)")
> Cc: stable@vger.kernel.org # v5.4
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>

Applied, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators
  2019-11-29 11:39 ` [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators Stefan Mavrodiev
@ 2019-12-02 19:16   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2019-12-02 19:16 UTC (permalink / raw)
  To: Stefan Mavrodiev
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-sunxi, open list, Chen-Yu Tsai, Rob Herring,
	moderated list:ARM/Allwinner sunXi SoC support


[-- Attachment #1.1: Type: text/plain, Size: 457 bytes --]

On Fri, Nov 29, 2019 at 01:39:40PM +0200, Stefan Mavrodiev wrote:
> Allwinner A64 SoC has separate supplies for PC, PD, PE, PG and PL. This
> patch adds regulators for them to the pinctrl node.
>
> Exception is PL which is used by the RSB bus. To avoid circular
> dependencies, VCC-PL is omitted.
>
> On boards with eMMC, VCC-PC is supplied by ELDO1, instead of DCDC1.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>

Queued for 5.6, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator
  2019-11-29 11:39 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator Stefan Mavrodiev
@ 2019-12-02 19:17   ` Maxime Ripard
  0 siblings, 0 replies; 7+ messages in thread
From: Maxime Ripard @ 2019-12-02 19:17 UTC (permalink / raw)
  To: Stefan Mavrodiev
  Cc: Mark Rutland,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	linux-sunxi, open list, stable, Chen-Yu Tsai, Rob Herring,
	moderated list:ARM/Allwinner sunXi SoC support


[-- Attachment #1.1: Type: text/plain, Size: 542 bytes --]

On Fri, Nov 29, 2019 at 01:39:41PM +0200, Stefan Mavrodiev wrote:
> A64-OLinuXino uses DCDC1 (VCC-IO) for MMC1 supply. In commit 916b68cfe4b5
> ("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi") ALDO2 is set, which is
> VCC-PL. Since DCDC1 is always present, the boards are working without a
> problem.
>
> This patch sets the correct regulator.
>
> Fixes: 916b68cfe4b5 ("arm64: dts: a64-olinuxino: Enable RTL8723BS WiFi")
> Cc: stable@vger.kernel.org # v4.16+
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>

Applied, thanks!
Maxime

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-12-02 19:17 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-29 11:39 [PATCH v2 0/3] arm64: dts: allwinner: a64: olinuxino: Update regulators Stefan Mavrodiev
2019-11-29 11:39 ` [PATCH v2 1/3] arm64: dts: allwinner: a64: olinuxino: Fix eMMC supply regulator Stefan Mavrodiev
2019-12-02 19:13   ` Maxime Ripard
2019-11-29 11:39 ` [PATCH v2 2/3] arm64: dts: allwinner: a64: olinuxino: Add bank supply regulators Stefan Mavrodiev
2019-12-02 19:16   ` Maxime Ripard
2019-11-29 11:39 ` [PATCH v2 3/3] arm64: dts: allwinner: a64: olinuxino: Fix SDIO supply regulator Stefan Mavrodiev
2019-12-02 19:17   ` Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).