From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B943C432C3 for ; Tue, 3 Dec 2019 07:03:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 015C020656 for ; Tue, 3 Dec 2019 07:03:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YRW1+/Zy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="E3kueX+7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 015C020656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Be9aH/4UjOLFPjyxCGoN+FqUGc1JS0qVISUTyWpneI=; b=YRW1+/Zyh0/zQ2 vWklPiMFavB6rZzq9OQ4We7ocX/PtvEcpLfA1+ns9SJBRvqRo4bjIdo1iWM4CCF4RPphGkDyOcI19 UOPmXXBpQjCBEH+UYqYaoT6KRPEqQSRabQDQNTBGVz9UK/kMZzxkeDaLKXsz/vwbbpduD1t3Fx6ra AStqmlH8id8TQJArBDC8tDHyy9HPnn+IUkK9khC7MaNNXoeM7wURRQeZLQ6HiZY1y314c53mSSW7K xmdW2OfFcrkm+hfi9yxKiE7Y2rQq2xbIdRHJo25ilu1Y6b7uOVDvBsU7U071xAQs9WWzCkZqlitk3 KEgAnhlAZVtmoC26APrg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2DB-0001Ym-LV; Tue, 03 Dec 2019 07:03:05 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ic2D6-0001Y8-8b; Tue, 03 Dec 2019 07:03:04 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DCEFE309; Tue, 3 Dec 2019 08:02:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575356577; bh=BHGcClPJ8faRIFKK7GdcaZ3ZNqYB59soqjub02MQB1U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3kueX+7poUsLlLNHNb8tDRtAIJFMNynguFfEhRjHD8V/rg8SOIyTvGI64Sm/v7sW kRat1924btOO2rZxPhXW1Fv6jz6Q2UvxV3F3RAYHjBZjx27fOnvFuVje9e9COANAEw Z4e9gqTJkCwCprwCs08uymK0XroFud5phDqLqJFY= Date: Tue, 3 Dec 2019 09:02:49 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 07/26] drm/panel: remove get_timings Message-ID: <20191203070249.GG4730@pendragon.ideasonboard.com> References: <20191202193230.21310-1-sam@ravnborg.org> <20191202193230.21310-8-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193230.21310-8-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_230300_594050_274123E2 X-CRM114-Status: GOOD ( 15.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Mon, Dec 02, 2019 at 08:32:11PM +0100, Sam Ravnborg wrote: > There was no users - so remove it. > The callback was implemented in two drivers - deleted. This looks good to me, so Reviewed-by: Laurent Pinchart but I'll let Thierry decide if he prefers keeping it. > Signed-off-by: Sam Ravnborg > Cc: Thierry Reding > Cc: Laurent Pinchart > Cc: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 18 ------------------ > drivers/gpu/drm/panel/panel-simple.c | 18 ------------------ > include/drm/drm_panel.h | 9 --------- > 3 files changed, 45 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > index b878930b17e4..3bcba64235c4 100644 > --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > @@ -217,30 +217,12 @@ static int seiko_panel_get_modes(struct drm_panel *panel, > return seiko_panel_get_fixed_modes(p, connector); > } > > -static int seiko_panel_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct seiko_panel *p = to_seiko_panel(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs seiko_panel_funcs = { > .disable = seiko_panel_disable, > .unprepare = seiko_panel_unprepare, > .prepare = seiko_panel_prepare, > .enable = seiko_panel_enable, > .get_modes = seiko_panel_get_modes, > - .get_timings = seiko_panel_get_timings, > }; > > static int seiko_panel_probe(struct device *dev, > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index d6299fe6d276..e225791a6fb2 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -326,30 +326,12 @@ static int panel_simple_get_modes(struct drm_panel *panel, > return num; > } > > -static int panel_simple_get_timings(struct drm_panel *panel, > - unsigned int num_timings, > - struct display_timing *timings) > -{ > - struct panel_simple *p = to_panel_simple(panel); > - unsigned int i; > - > - if (p->desc->num_timings < num_timings) > - num_timings = p->desc->num_timings; > - > - if (timings) > - for (i = 0; i < num_timings; i++) > - timings[i] = p->desc->timings[i]; > - > - return p->desc->num_timings; > -} > - > static const struct drm_panel_funcs panel_simple_funcs = { > .disable = panel_simple_disable, > .unprepare = panel_simple_unprepare, > .prepare = panel_simple_prepare, > .enable = panel_simple_enable, > .get_modes = panel_simple_get_modes, > - .get_timings = panel_simple_get_timings, > }; > > #define PANEL_SIMPLE_BOUNDS_CHECK(to_check, bounds, field) \ > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index 4fd61cb9eb93..c4e82b9ce586 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -102,15 +102,6 @@ struct drm_panel_funcs { > */ > int (*get_modes)(struct drm_panel *panel, > struct drm_connector *connector); > - > - /** > - * @get_timings: > - * > - * Copy display timings into the provided array and return > - * the number of display timings available. > - */ > - int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > - struct display_timing *timings); > }; > > /** -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel