From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Eugen Hristev - M18282 <Eugen.Hristev@microchip.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Codrin Ciubotariu - M19940 <Codrin.Ciubotariu@microchip.com>,
"peda@axentia.se" <peda@axentia.se>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] i2c: at91: remote default value initialization
Date: Tue, 3 Dec 2019 08:13:32 +0100 [thread overview]
Message-ID: <20191203071332.zwpmeb65g7e7ckmj@M43218.corp.atmel.com> (raw)
In-Reply-To: <1575276957-5615-3-git-send-email-eugen.hristev@microchip.com>
On Mon, Dec 02, 2019 at 09:56:41AM +0100, Eugen Hristev - M18282 wrote:
> From: Eugen Hristev <eugen.hristev@microchip.com>
>
> Platform data structs are initialized by default with zero values.
> Thus it becomes redundant to initialize them manually to zero (false).
> Remove extra false initialization for field members in structs.
>
> Suggested-by: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Honestly, I prefer an explicit description than saving lines of code, in
a glance you have all the details, don't need to go back to the
structure definition.
As it's a personal belief, I won't argue about it.
Reviewed-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> ---
> drivers/i2c/busses/i2c-at91-core.c | 39 --------------------------------------
> 1 file changed, 39 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
> index 5137e62..3da1a8a 100644
> --- a/drivers/i2c/busses/i2c-at91-core.c
> +++ b/drivers/i2c/busses/i2c-at91-core.c
> @@ -66,55 +66,26 @@ static struct at91_twi_pdata at91rm9200_config = {
> .clk_max_div = 5,
> .clk_offset = 3,
> .has_unre_flag = true,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata at91sam9261_config = {
> .clk_max_div = 5,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata at91sam9260_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata at91sam9g20_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata at91sam9g10_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static const struct platform_device_id at91_twi_devtypes[] = {
> @@ -142,23 +113,13 @@ static const struct platform_device_id at91_twi_devtypes[] = {
> static struct at91_twi_pdata at91sam9x5_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> - .has_hold_field = false,
> - .has_dig_filtr = false,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata sama5d4_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> - .has_unre_flag = false,
> - .has_alt_cmd = false,
> .has_hold_field = true,
> .has_dig_filtr = true,
> - .has_adv_dig_filtr = false,
> - .has_ana_filtr = false,
> };
>
> static struct at91_twi_pdata sama5d2_config = {
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-03 7:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 8:56 [PATCH 1/3] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-02 8:56 ` [PATCH 2/3] i2c: at91: fix clk_offset for sama5d2 Eugen.Hristev
2019-12-02 9:01 ` [PATCH v2 2/3] i2c: at91: fix clk_offset for sam9x60 Eugen.Hristev
2019-12-03 7:01 ` Ludovic Desroches
2019-12-06 16:58 ` [PATCH 2/3] i2c: at91: fix clk_offset for sama5d2 Codrin.Ciubotariu
2019-12-02 8:56 ` [PATCH 3/3] i2c: at91: remote default value initialization Eugen.Hristev
2019-12-03 7:13 ` Ludovic Desroches [this message]
2019-12-03 6:57 ` [PATCH 1/3] dt-bindings: i2c: at91: cosmetic formatting of compatible list Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203071332.zwpmeb65g7e7ckmj@M43218.corp.atmel.com \
--to=ludovic.desroches@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Eugen.Hristev@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).