From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: soc@kernel.org, arm@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: pxa: Fix resource properties
Date: Tue, 3 Dec 2019 12:48:31 +0200 [thread overview]
Message-ID: <20191203104831.GN32742@smile.fi.intel.com> (raw)
In-Reply-To: <20191203104117.85517-1-linus.walleij@linaro.org>
On Tue, Dec 03, 2019 at 11:41:17AM +0100, Linus Walleij wrote:
> The conversion to properties changed one assignment and
> missed three other assignments in the same file, fix it
> up so the platform compiles.
>
> The bug was reported by a few build bots but noone noticed.
> I noticed it when making other changes to the PXA platforms.
Ah, indeed, I compiled it on x86.
Thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Fixes: 50ec88120ea1 ("can: mcp251x: get rid of legacy platform data")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC folks: please apply this directly for fixes.
> ---
> arch/arm/mach-pxa/icontrol.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/icontrol.c b/arch/arm/mach-pxa/icontrol.c
> index 0474a4b1394d..151e26ec0696 100644
> --- a/arch/arm/mach-pxa/icontrol.c
> +++ b/arch/arm/mach-pxa/icontrol.c
> @@ -89,7 +89,7 @@ static struct spi_board_info mcp251x_board_info[] = {
> .max_speed_hz = 6500000,
> .bus_num = 3,
> .chip_select = 1,
> - .platform_data = &mcp251x_info,
> + .properties = mcp251x_properties,
> .controller_data = &mcp251x_chip_info2,
> .irq = PXA_GPIO_TO_IRQ(ICONTROL_MCP251x_nIRQ2)
> },
> @@ -98,7 +98,7 @@ static struct spi_board_info mcp251x_board_info[] = {
> .max_speed_hz = 6500000,
> .bus_num = 4,
> .chip_select = 0,
> - .platform_data = &mcp251x_info,
> + .properties = mcp251x_properties,
> .controller_data = &mcp251x_chip_info3,
> .irq = PXA_GPIO_TO_IRQ(ICONTROL_MCP251x_nIRQ3)
> },
> @@ -107,7 +107,7 @@ static struct spi_board_info mcp251x_board_info[] = {
> .max_speed_hz = 6500000,
> .bus_num = 4,
> .chip_select = 1,
> - .platform_data = &mcp251x_info,
> + .properties = mcp251x_properties,
> .controller_data = &mcp251x_chip_info4,
> .irq = PXA_GPIO_TO_IRQ(ICONTROL_MCP251x_nIRQ4)
> }
> --
> 2.23.0
>
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-12-03 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:41 [PATCH] ARM: pxa: Fix resource properties Linus Walleij
2019-12-03 10:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203104831.GN32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arm@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).