From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E91CC432C0 for ; Tue, 3 Dec 2019 15:45:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C5872073C for ; Tue, 3 Dec 2019 15:45:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mxmfLZQJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C5872073C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=N+ouwCQ09iTffbfS8y0rsbHeYNk9kQKqxqsBFn7pYFQ=; b=mxmfLZQJgXIywo wI0jkoXijwekztcjXtG9flAqKf3XpoJLmR9+JH74cvQi1gXxUi8DsAbB4E69SOnmyEq1DPZycfdDL AS8RMRv2F+9k0TDGOStZ22EUk3AUYlbiYGky3w2ols0+k1TicMdA1po9K8u2uRQwJxF5T0Q+5kY/l NOHfN+vCGTSX2Rd8aEGGidTSK4x4spdg5rc1gaHTPofkkZVMmtRHWCWw63lxu69DMkfHRXmqjl6Kz Y6khnwr6nf2RFaTyxC6gq3kMwAkswxo/CmfL/Hm5ekP1jA6qFMGsiciSdqqFQYIZ3MSYYoLK6B019 K/CqserStu8dpsOPmNfQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icAMC-0006XG-M7; Tue, 03 Dec 2019 15:44:56 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icAM9-0006WI-8j for linux-arm-kernel@lists.infradead.org; Tue, 03 Dec 2019 15:44:54 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E047F804F; Tue, 3 Dec 2019 15:45:28 +0000 (UTC) Date: Tue, 3 Dec 2019 07:44:47 -0800 From: Tony Lindgren To: "H. Nikolaus Schaller" Subject: Re: [PATCH] ARM: OMAP2+: Fix warnings with broken omap2_set_init_voltage() Message-ID: <20191203154447.GC35479@atomide.com> References: <20190924233222.52757-1-tony@atomide.com> <8FFD44DB-73F8-4807-91E1-C97DA8F781BA@goldelico.com> <20191202213929.GB35479@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_074453_346823_EB291DA1 X-CRM114-Status: GOOD ( 15.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Linux-OMAP , Linux Kernel Mailing List , Tero Kristo , Andreas Kemnade , =?utf-8?B?QW5kcsOp?= Roth , Discussions about the Letux Kernel , Adam Ford , arm-soc Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * H. Nikolaus Schaller [191203 12:31]: > Ok, dev_pm_opp_find_freq_ceil() is doing what it should do and it > returns the first OPP higher or equal than the frequency passed in. > > The real reason for the warning is that the same OPP table is used > for vdd_mpu_iva and vdd_core and it appears as if "core" (l3_ick) > runs at 200 MHz which does not correspond to a valid OPP. OK > So to silcence the warning it suffices to remove > > omap2_set_init_voltage("core", "l3_ick", "l3_main"); > > The question is now what l3_ick has to do with the OPPs at all > and how it should interwork with OPPs and cpufreq. So what changed then for iva in your configuration then? At least I'm getting errors for both for 34xx and dm3730 with Linux next and reverted commit cf395f7ddb9e ("ARM: OMAP2+: Fix warnings with broken omap2_set_init_voltage()"): omap2_set_init_voltage: unable to find boot up OPP for vdd_mpu_iva omap2_set_init_voltage: unable to set vdd_mpu_iva omap2_set_init_voltage: unable to find boot up OPP for vdd_core omap2_set_init_voltage: unable to set vdd_core Then for fixing this code, seems like this can all happen from a regular device driver init based on the dts data.. We've had PM init completely ignore these errors already for years so whatever dependency there might be seems non-critical :) > Or does all this mean we may need a second OPP fable for vdd_core > and 200 MHz? But what would it be good for? I have not seen any > reference for "core-OPPs" in the TRM. OK yeah sounds like all the domains need an opp table. Also, I recall some SoCs having a dependency between having to run DSP at a lower rate for higher MPU rates, not sure if omap3 has such dependencies though. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel