From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC62C432C0 for ; Tue, 3 Dec 2019 22:37:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F9882073C for ; Tue, 3 Dec 2019 22:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FKpy2Ej+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F9882073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oYX9qPjyTMCV3UKDF6WwLrxyhjjy3B2LjAkQriQGDPQ=; b=FKpy2Ej+/sboku 0seHWKNKK+Z/NHyOTQ3iiwHUUl+NAJ0DoA3EE1IAynFT20YJCQ7OBuQPy8NA82dpOw2pYkIYidDv9 dHdl6uoC2WpRRO+E63gC4A1A6sICYG1PGI716Qtb6CD6mTpsLjkXVAnnXqYyuDz+iANMFtHsmivuf Vg69HpBiFMpDpdadKSMvo6H8cPs2InLo39P0GRoOxzI0KjxuffH+32OMZ42KBJ2Dxj3Yam0CLx5+i INCMR6/uWKyB4uvtGk5IPRfQeWPEjaDwCvumCa4rOcenPQ7qWkB7wY4t+SKpRpv70R6YckPhz7lLR wZc4tYsEek7OP9SmOOnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icGn7-000572-EG; Tue, 03 Dec 2019 22:37:09 +0000 Received: from mail-oi1-f196.google.com ([209.85.167.196]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icGn3-00055v-SM; Tue, 03 Dec 2019 22:37:07 +0000 Received: by mail-oi1-f196.google.com with SMTP id 6so4967651oix.7; Tue, 03 Dec 2019 14:37:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NnWqN+v6idF+rYohPBc8yK8WHdS4XunbYI4eJ0qCx44=; b=R50tlexcX0fIWyvZrOSQXVmGxQ8r/JqJTo18Sy4bUwV2fVpBr0jJ8A49tyXvgDZ5Ye y80P8NpqtT7SFD6b7yX9z3L9t39BAdMGp53aDqsFnZFJHojLCI+lQGVk/kPOkwZWfKvw 0jlgM6QPstOZKEVz6djimG5Ssb8ll8jJ8tAekqjDAJiSBzSlxL6LZz950obyTX8UXaQ5 hgJjZTCj7JhksQU32GXbreDSvXKvsRlqfhxc2Hn8d23gSTUr3tZ0UsTYXLWYQSvEZGLU AzZQHdkaivp4NHrVzc4UuJbGYP1tMC6eDTzA95G0gRrjgOCh9ZcS/T3Im03AqKUY4mKf xHHA== X-Gm-Message-State: APjAAAXvkk6dWtq2pWVdbc4/xWFgQZfnCNqjLRQhzfj9PylV6BfkfchW 1N1u+sXSGnqIiBLL+wEVxQ== X-Google-Smtp-Source: APXvYqyY+MvnuM+hiACvXhy/3tKtbTc72UkG95+81S0zipokTze6+5MxpHqRBYpAnCxnfaY6IROUJQ== X-Received: by 2002:aca:4cc7:: with SMTP id z190mr996oia.10.1575412625132; Tue, 03 Dec 2019 14:37:05 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id m2sm1615150oim.13.2019.12.03.14.37.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2019 14:37:04 -0800 (PST) Date: Tue, 3 Dec 2019 16:37:04 -0600 From: Rob Herring To: Jagan Teki Subject: Re: [PATCH v2 1/2] dt-bindings: arm: rockchip: Add libretech for roc-pc binding Message-ID: <20191203223704.GA29109@bogus> References: <20191119185817.11216-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191119185817.11216-1-jagan@amarulasolutions.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_143705_917439_3C4696A7 X-CRM114-Status: GOOD ( 16.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Da Xue , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Akash Gajjar , Levin Du , linux-amarula@amarulasolutions.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 20, 2019 at 12:28:16AM +0530, Jagan Teki wrote: > Though the ROC-PC is manufactured by firefly, it is co-designed > by libretch like other Libretech computer boards from allwinner, > amlogic does. > > It is always meaningful to keep maintain those vendors who are > part of design participation, so add libretech roc-pc compatible > with existing binding. Maybe so, but this is pretty pointless if it's not different h/w. Compatible strings are simply a h/w identifier. > Signed-off-by: Jagan Teki > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index f7470ed1e17d..45728fd22af8 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -100,6 +100,7 @@ properties: > - description: Firefly ROC-RK3399-PC > items: > - enum: > + - libretech,roc-rk3399-pc > - firefly,roc-rk3399-pc > - firefly,roc-rk3399-pc-mezzanine This doesn't match your change in the dts. file. The schema says there are 2 strings with the first one being 1 of these 3. > - const: rockchip,rk3399 > -- > 2.18.0.321.gffc6fa0e3 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel