From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B156C432C0 for ; Wed, 4 Dec 2019 02:19:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2212073C for ; Wed, 4 Dec 2019 02:19:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PK0i4XSq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="vr3fYKnx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2212073C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=psxcFcytdq4uYxVYtcPz/DFm77gnAbSf2uGGx1/nnrU=; b=PK0i4XSqTPq4LQ Nd4XywVyv36AnNJtXVC4mie6TrsK1ItnbO42hYmQq6PYR9AKgy/vRmCZWXaxHdsSseOac6ahZBuFh BIz7rMjuNPxvAx8tcPEd+NL/2xucJuiJT117S+ATkDFp8Qb1YrKfPA07TcpDNme3plUfeRhRgew0B v6lKIn51lxoJizg08ZcfEeVr9CZnriPSSc0hb5l6jUqA16o0ZgCLfTw1AFnR4D3t7XyjXwV5U9ktG Jh366sYXjqj5rfUY9R5ymPIIdBLCJa0hwrT9QrYnkjbxWuU9uPT0gDoG2CJOtfHXHSN2pb/9tY4JF rbFIb7mZj5yVdnECrHvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icKG9-0004uH-Kh; Wed, 04 Dec 2019 02:19:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icKG5-0004tl-9u for linux-arm-kernel@lists.infradead.org; Wed, 04 Dec 2019 02:19:20 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10B8C2073C; Wed, 4 Dec 2019 02:19:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575425956; bh=FX0SbHl1Yljp4OhiB2FkaDSP/AYuFcF8lh80Js4Mc/c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vr3fYKnxYmLmrDqk2Jr6lZOynJiZfJSLzX8Pp8YPusqwp3A8PXmRWEUAI0nnKG9A/ vwo2NmNoTfqzw8dGnojNcemy6+kQcl023nXPZiXz1ER1PxNojyMAXBA1rzQAPpIw/a PTYizRwVD2Slkvb9eF8GO4DUlF+PGVQKuF1bjAwI= Date: Wed, 4 Dec 2019 10:19:09 +0800 From: Shawn Guo To: Peng Fan Subject: Re: [PATCH] clk: imx: pll14xx: fix clk_pll14xx_wait_lock Message-ID: <20191204021908.GN9767@dragon> References: <1573018178-14939-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573018178-14939-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_181917_369491_FA395F8D X-CRM114-Status: GOOD ( 16.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , Abel Vesa , "sboyd@kernel.org" , "s.hauer@pengutronix.de" , "linux-kernel@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , Leonard Crestez , "festevam@gmail.com" , "linux-clk@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 06, 2019 at 05:31:15AM +0000, Peng Fan wrote: > From: Peng Fan > > The usage of readl_poll_timeout is wrong, the cond should be > "val & LOCK_STATUS" not "val & LOCK_TIMEOUT_US". Is this caught just by code inspection or a real world bug? If you want this get into -rc (and stable kernel) as a fix, you should add more information about the bug, like how it's been triggered, what's the consequence of the bug, and kernel dump message etc. > > Fixes: 8646d4dcc7fb ("clk: imx: Add PLLs driver for imx8mm soc") > Signed-off-by: Peng Fan > --- > > V1: > Hi Shawn, > This patch is made based on 5.4-rc6, not your for-next branch, Please rebase it on 5.5-rc1 which will be coming next Monday. > not sure whether this patch could catch 5.4 release. You can Cc stable kernel, so that it will be back ported. Shawn > > drivers/clk/imx/clk-pll14xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c > index 7a815ec76aa5..d43b4a3c0de8 100644 > --- a/drivers/clk/imx/clk-pll14xx.c > +++ b/drivers/clk/imx/clk-pll14xx.c > @@ -153,7 +153,7 @@ static int clk_pll14xx_wait_lock(struct clk_pll14xx *pll) > { > u32 val; > > - return readl_poll_timeout(pll->base, val, val & LOCK_TIMEOUT_US, 0, > + return readl_poll_timeout(pll->base, val, val & LOCK_STATUS, 0, > LOCK_TIMEOUT_US); > } > > -- > 2.16.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel