From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> To: Qian Cai <cai@lca.pw> Cc: pmladek@suse.com, tytso@mit.edu, sergey.senozhatsky.work@gmail.com, Arnd Bergmann <arnd@arndb.de>, peterz@infradead.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, linux-mm@kvack.org, Catalin Marinas <catalin.marinas@arm.com>, longman@redhat.com, dan.j.williams@intel.com, will@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] char/random: silence a lockdep splat with printk() Date: Thu, 5 Dec 2019 10:00:55 +0900 Message-ID: <20191205010055.GO93017@google.com> (raw) In-Reply-To: <637027D4-BBDD-4AA6-B03C-556060988957@lca.pw> Hi, On (19/12/03 13:46), Qian Cai wrote: > > On Nov 13, 2019, at 4:16 PM, Qian Cai <cai@lca.pw> wrote: > > > > From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> > > > > Sergey didn't like the locking order, > > > > uart_port->lock -> tty_port->lock > > > > uart_write (uart_port->lock) > > __uart_start > > pl011_start_tx > > pl011_tx_chars > > uart_write_wakeup > > tty_port_tty_wakeup > > tty_port_default > > tty_port_tty_get (tty_port->lock) > > > > but those code is so old, and I have no clue how to de-couple it after > > checking other locks in the splat. There is an onging effort to make all > > printk() as deferred, so until that happens, workaround it for now as a > > short-term fix. > > Sergey, could we have a ACK from you so Ted might be able to merge? Not sure if I can ACK it, but overall it makes sense to use deferred printk there. [..] > > > [cai@lca.pw: add a commit log.] > > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> > > Signed-off-by: Qian Cai <cai@lca.pw> > > --- > > > > Sergey, please let us know if you are fine with the Signed-off-by. A 'Reviewed-by' will suffice. Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com> -ss _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply index Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-13 21:16 Qian Cai 2019-12-03 18:46 ` Qian Cai 2019-12-05 1:00 ` Sergey Senozhatsky [this message]
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191205010055.GO93017@google.com \ --to=sergey.senozhatsky.work@gmail.com \ --cc=arnd@arndb.de \ --cc=cai@lca.pw \ --cc=catalin.marinas@arm.com \ --cc=dan.j.williams@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=longman@redhat.com \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=rostedt@goodmis.org \ --cc=tglx@linutronix.de \ --cc=tytso@mit.edu \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git