From: Sascha Hauer <s.hauer@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: aisheng.dong@nxp.com, Biwen Li <biwen.li@nxp.com>,
linux-arm-kernel@lists.infradead.org, wsa@the-dreams.de,
shawnguo@kernel.org, xiaobo.xie@nxp.com, leoyang.li@nxp.com,
xiaoning.wang@nxp.com, linux-imx@nxp.com, kernel@pengutronix.de,
jiafei.pan@nxp.com, laurentiu.tudor@nxp.com, festevam@gmail.com,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [v6] i2c: imx: support slave mode for imx I2C driver
Date: Fri, 6 Dec 2019 08:38:20 +0100 [thread overview]
Message-ID: <20191206073819.lntjjxpcjm5yrb7y@pengutronix.de> (raw)
In-Reply-To: <9a1a00c1-e9fa-36a1-0e79-3492d9b98d9f@pengutronix.de>
On Thu, Dec 05, 2019 at 12:43:46PM +0100, Oleksij Rempel wrote:
> Hi,
>
> On 04.12.19 11:00, Sascha Hauer wrote:
> > Hi,
> >
> > The patch looks ok to me now, but I still do not like the #ifdeffery
> > around CONFIG_I2C_SLAVE. With the patch I just sent (You are on Cc:)
> > we could apply the following on your patch which makes it more readable
> > and increases compile coverage.
> >
> > Wolfram, Biwen, what do you think?
>
>
> RCAR depends on slave:
> config I2C_RCAR
>
> tristate "Renesas R-Car I2C Controller"
>
> depends on ARCH_RENESAS || COMPILE_TEST
>
> select I2C_SLAVE
> see:
> drivers/i2c/busses/i2c-rcar.c
>
> So, I would suggest to do the same in imx.
I suggested that to v1 of this patch. If we agree though that I2C slave
support deserves an extra Kconfig option we should also make the drivers
cope with that situation. Otherwise we would better make I2C slave
support non optional.
Sascha
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-06 7:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 11:48 [v6] i2c: imx: support slave mode for imx I2C driver Biwen Li
2019-12-04 10:00 ` Sascha Hauer
2019-12-05 11:43 ` Oleksij Rempel
2019-12-06 7:38 ` Sascha Hauer [this message]
2020-03-04 4:13 ` [EXT] " Biwen Li
2020-03-04 5:22 ` Oleksij Rempel
2020-03-04 6:54 ` Biwen Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206073819.lntjjxpcjm5yrb7y@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=aisheng.dong@nxp.com \
--cc=biwen.li@nxp.com \
--cc=festevam@gmail.com \
--cc=jiafei.pan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.tudor@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wsa@the-dreams.de \
--cc=xiaobo.xie@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).