From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 604F6C43603 for ; Mon, 9 Dec 2019 20:03:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32227207FF for ; Mon, 9 Dec 2019 20:03:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KBnaBpGh"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EpZ4LttE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32227207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zDwbBkXeXsxLXGIc5VK3CPEzFoTgEO5gYXfCmAk5wjI=; b=KBnaBpGhHgKBFh 2fTiZl/2kRdxldzwImBJKncrATYu6/kgL7HD4NXolGsm1DxZZXhllvNbgs3PZZkvCZEFwexqS5lhq Xnz0r/gfTimBLo1YaeRI6xLHAY4uU3jQTP3pvt7VTzJPF3sJOumYMllY5RZ+GV4tub8g03PvovA+d idoFPgz1Iya5CHVAwjGObiJDc13t+RIFmgBxo0lvzwWxYGIVmJrNp5GLqJy9Ulb2AW3X7huLu9qTt yWSsw51nPY93pnEWaw6Ohrnkj04MCEhCvh6nrMoH9EaJGT+Ak0gAOufjqsiRGOZSYAZ/7a1XYegOe YPikDs2n/2V4tDvUcfAw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iePFo-0005JR-IV; Mon, 09 Dec 2019 20:03:36 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iePFl-0005IP-BG for linux-arm-kernel@lists.infradead.org; Mon, 09 Dec 2019 20:03:34 +0000 Received: from localhost (lfbn-1-10718-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E3072073D; Mon, 9 Dec 2019 20:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575921812; bh=A0I5xt4XVITb5z+wlWL8aR+iy4vFVHNdEWorhG4GJ/Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EpZ4LttEWn+/f/Y3V6o4s1cgDDhtTtCGT82reKJT064VK/o1My1nkUMsM79YglWwX R7Zwgd0VkHepPrARH41qnKM9B8sdt7DnN0/1mdbe7Br1ZnU0EkMZJMmGOnbSfTt+AE hkqHJWZVKPdB6H94t2fQDteb8ikwRSiClkiVHGK0= Date: Mon, 9 Dec 2019 20:31:12 +0100 From: Maxime Ripard To: Vasily Khoruzhick Subject: Re: [PATCH] arm64: dts: allwinner: a64: set GPU clock to 432 MHz Message-ID: <20191209193112.qr6un5ryhyxwu6a5@hendrix.lan> References: <20191203021420.164129-1-anarsoul@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191203021420.164129-1-anarsoul@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191209_120333_409247_0BB866E8 X-CRM114-Status: GOOD ( 14.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon, Dec 02, 2019 at 06:14:20PM -0800, Vasily Khoruzhick wrote: > That's what BSP kernel sets it to and it seems to work fine. > > Signed-off-by: Vasily Khoruzhick > --- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > index 27e48234f1c2..0051f39b3d98 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi > @@ -976,6 +976,9 @@ mali: gpu@1c40000 { > clocks = <&ccu CLK_BUS_GPU>, <&ccu CLK_GPU>; > clock-names = "bus", "core"; > resets = <&ccu RST_BUS_GPU>; > + > + assigned-clocks = <&ccu CLK_GPU>; > + assigned-clock-rates = <432000000>; > }; This doesn't really guarantee anything. If the GPU needs to remain at that rate, it should be set in the driver. I just saw that you did send a PR in github, I just merged it. Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel