From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28663C43603 for ; Thu, 12 Dec 2019 16:22:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFAF8214AF for ; Thu, 12 Dec 2019 16:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lqTkkXBK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFAF8214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TSCmbU0v2xMA1g+5u2h+MUfHCEstGuJwfszbecaq7A0=; b=lqTkkXBKfcv0v0 j//F15+cAZB+lSIeYOa78X5RgbKMXw5i9L6gn6X/OzlOlNKcUUnKPK6SlLQYWPnJMPhbnnpyMx6q/ oMBsj5MGnAfnR5KkIBp3g4JzuHvLGOja8Gc4Rq93U+IoShaT+wtHS4qmHs1Oj2ywcWbbNH3X68Jai VE/L1cMK2IVgVPh/4C5fTakh/NIHrTJ0lBBVehiWQiCXmPq5LQJJFeA6CyjvHycty4tYc+I8v5G5p CnTSoJellkiNq6zw9y0SkQwQFfHUrZqowjqLEVXxFXqndOTLCAXrnaH9sWF+FH066l8oq9pfB3cUP eUCBz3KBM9zrYV8jlKPQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifREE-0001t6-56; Thu, 12 Dec 2019 16:22:14 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifREA-0001s3-VK for linux-arm-kernel@lists.infradead.org; Thu, 12 Dec 2019 16:22:12 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ifRDw-0005fc-Ik; Thu, 12 Dec 2019 17:21:56 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ifRDt-0007Ok-4v; Thu, 12 Dec 2019 17:21:53 +0100 Date: Thu, 12 Dec 2019 17:21:53 +0100 From: Marco Felsch To: Mark Brown Subject: Re: [PATCH v3 3/6] dt-bindings: mfd: da9062: add regulator voltage selection documentation Message-ID: <20191212162152.5uu3feacduetysq7@pengutronix.de> References: <20191129172537.31410-1-m.felsch@pengutronix.de> <20191129172537.31410-4-m.felsch@pengutronix.de> <20191204134631.GT1998@sirena.org.uk> <20191210094144.mxximpuouchy3fqu@pengutronix.de> <20191211170918.q7kqkd4lrwwp7jl3@pengutronix.de> <20191212161019.GF4310@sirena.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191212161019.GF4310@sirena.org.uk> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 17:17:35 up 27 days, 7:36, 37 users, load average: 0.01, 0.04, 0.08 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191212_082211_009016_40FBE67F X-CRM114-Status: GOOD ( 15.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Support Opensource , "linux-aspeed@lists.ozlabs.org" , "linux-gpio@vger.kernel.org" , "andrew@aj.id.au" , "linus.walleij@linaro.org" , "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" , "bgolaszewski@baylibre.com" , "robh+dt@kernel.org" , "joel@jms.id.au" , "kernel@pengutronix.de" , Adam Thomson , "lee.jones@linaro.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 19-12-12 16:10, Mark Brown wrote: > On Wed, Dec 11, 2019 at 06:09:18PM +0100, Marco Felsch wrote: > > > so one argument more for my solution. Also we don't configure the "pad" > > to be a vsel/ena-pin. The hw-pad can only be a gpio or has an alternate > > function (WDKICK for GPIO0, Seq. SYS_EN for GPIO2, Seq. PWR_EN for GPIO4). > > Instead we tell the regulator to use _this_ GPIO e.g. for voltage > > selection so we go the other way around. My last argument why pinctrl > > isn't the correct place is that the GPIO1 can be used for > > regulator-0:vsel-in and for regulator-1:enable-in. So this pad would > > have different states which is invalid IMHO. > > Note that there's two bits to my concern - one is if we should be using > gpiolib or pinctrl, the other is what's driving the input (whichever API > it's configured through) which didn't seem to be mentioned. gpiolib or pinctrl: I pointed out all my arguments above so I think it is time for Linus. "... what's driving the input ..": Sorry I didn't get you here. What did you mean? The input is driven by the host. This can be any gpio line and in my case it is a gpio line driven by the soc-hw during a suspend operation. Regards, Marco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel