From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CA3C43603 for ; Fri, 13 Dec 2019 22:27:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD1E22077B for ; Fri, 13 Dec 2019 22:27:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HlM73hLE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD1E22077B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kpQpjV8Fblm5dxnYKOMQ/Do3htvasZZvfnEHceL5g/Q=; b=HlM73hLErwavsmTwD70iYOlbJ h3CZ1FGHJtONnqH1RC8HZGJr+3YYl3hldsxRfkj0YVTBd611tNS7Bw/mPgQb2QFISXdnuxtm9FvKP m3XnY8Kiye8echOfP5tphicU/8aYz3jeALnayQOlLjRDrjWW5upZ6mCVP6+u2zSJJgAqWlo0KFmUH 3JxpnYVfarOTLGoCZSed80dd/ke6F2+HIog2JOzF7mggmFtC6AsJRHVemxtKM4I4ziLcxDAUS0wpB tlByzSFX/Q41qk28m241u/fiiwCIT6TfGiRK5OYYC9EmgoWhrUZvffcDzFjOK3PJE/rC0pqcEt2zz sibCGwa1w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifjKK-0002SO-H8; Fri, 13 Dec 2019 11:41:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifjKH-0002RO-Bc; Fri, 13 Dec 2019 11:41:42 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA0301045; Fri, 13 Dec 2019 03:41:40 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2911E3F718; Fri, 13 Dec 2019 03:41:40 -0800 (PST) Date: Fri, 13 Dec 2019 11:41:38 +0000 From: Mark Brown To: Jim Quinlan Subject: Re: [PATCH] spi: bcm2835: don't print error on clk_get() DEFER Message-ID: <20191213114138.GB4644@sirena.org.uk> References: <20191212231213.29061-1-jquinlan@broadcom.com> MIME-Version: 1.0 In-Reply-To: <20191212231213.29061-1-jquinlan@broadcom.com> X-Cookie: Life exists for no known purpose. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_034141_443369_C845C1BD X-CRM114-Status: GOOD ( 11.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Florian Fainelli , Scott Branden , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Ray Jui , Nicolas Saenz Julienne Content-Type: multipart/mixed; boundary="===============5628625408574052111==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5628625408574052111== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2B/JsCI69OhZNC5r" Content-Disposition: inline --2B/JsCI69OhZNC5r Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 12, 2019 at 06:12:13PM -0500, Jim Quinlan wrote: > Otherwise one may get multiple error messages for normal > operation of a clock provider. > if (IS_ERR(bs->clk)) { > err = PTR_ERR(bs->clk); > - dev_err(&pdev->dev, "could not get clk: %d\n", err); > + if (err != -EPROBE_DEFER) > + dev_err(&pdev->dev, "could not get clk: %d\n", err); On the other hand if the clock isn't there and never appears then there won't be anything saying why the driver isn't loading which won't be helpful when trying to figure out what's going on. --2B/JsCI69OhZNC5r Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3zePEACgkQJNaLcl1U h9BHDQf+Kf+RYd7moLj8bCbIPnaZZ7Nsho3jFNQaB96HmWNc0rO3oRC2CHPcW7Az EAw9GHh64sKQ+iLsXXIj5WhkBFfx0XsQ4uRSMCHwvpfnYaWw9a4ntAYr8Q6D7T5Y RZQgixN7JobxgbUrL50FdhBJFz/Jjcc0a5N6xYrD8xNQDFlmnMtmqVpN9PBQlzp5 hdDU5eDqz0ncgiyJMsMUoEyoUtdjXJKWFcJtuEJ51bi/ken7MVU/m3CO806jkW9O jk+OV2OMytB67pvLZyenL7pXLmkpP45Vpcb+elTkBBFiTDOsNsWkBxEhrQ1qxowF Db335irZY42aFsjJkwvOx+C8Nc+qIA== =EGVJ -----END PGP SIGNATURE----- --2B/JsCI69OhZNC5r-- --===============5628625408574052111== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5628625408574052111==--