From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=DATE_IN_PAST_03_06, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BCFC43603 for ; Fri, 13 Dec 2019 22:31:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C653A20706 for ; Fri, 13 Dec 2019 22:31:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KVdEiwEw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PeEofRhs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C653A20706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WVlZXnXHoyXuuhd3WTDD2ZwjFuTj1IxV9SBNrqz1Tck=; b=KVdEiwEwE48J5L d7z6s/kCYghJT8T2LTWczSGrrjBYhu09ONZULV025cRP5FyXyczqoliv3UGm0MlpK+qBzsEVusf3F h+iiiokkCsEkfaWGMDA/LqOap8pV9WTgqS4KYbAAJ4LPy63k4SxO3ww43NrUTQrgV1so6Pyqzkrou mRQOcUnQAYYHv2SPRMUea0ZcImSI/dSsmZlqixT6qCIyIWow+PvFh0rYaKh6wckNNKuymJTeA79BZ vWhxCVqG+gh7B6Gc0jHUkh1O/Mh6sAvQIDg5/A45JtSoRn/7fZsyjL6VKnG33UF18MOGOb5+xVRRW hL8U/f/KhMs1jKYfoWOA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifsnv-0006b3-Ri; Fri, 13 Dec 2019 21:48:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifsnt-0006aM-1X for linux-arm-kernel@lists.infradead.org; Fri, 13 Dec 2019 21:48:54 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E51772465A; Fri, 13 Dec 2019 21:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576273731; bh=W6PNMUKclSNiyukyuEfFoNLFmNoXI+aexIYgZ4MTdjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PeEofRhsCvjZ+oPbAqR3cXLYfTQrMxwVJwTPrn2WP14QZe/PuCvRGUlRXNDZ6L22p UNxVsIZmRGhOh7RIjhSqn/YG+VgeeZM0YsLYAovRdNf5reI1pvJr3oq5XoxQmmHWrg Yf7uhsv8CrEa5gmU7TN4t3Be9otvEyQCgL+krue4= Date: Fri, 13 Dec 2019 17:07:26 +0100 From: Greg KH To: David Engraf Subject: Re: [PATCH v2] tty/serial: atmel: fix out of range clock divider handling Message-ID: <20191213160726.GB2632926@kroah.com> References: <1e2e3f63-84db-4b38-1bf1-85916116e0a2@sysgo.com> <20191213140301.16490-1-david.engraf@sysgo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191213140301.16490-1-david.engraf@sysgo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_134853_104079_C87BED43 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, richard.genoud@gmail.com, linux-kernel@vger.kernel.org, ludovic.desroches@microchip.com, linux-serial@vger.kernel.org, jslaby@suse.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 13, 2019 at 03:03:01PM +0100, David Engraf wrote: > Use MCK_DIV8 when the clock divider is > 65535. Unfortunately the mode > register was already written thus the clock selection is ignored. > > Fix by doing the baud rate calulation before setting the mode. > > Fixes: 5bf5635ac170 ("tty/serial: atmel: add fractional baud rate support") > Signed-off-by: David Engraf > --- > drivers/tty/serial/atmel_serial.c | 43 ++++++++++++++++--------------- > 1 file changed, 22 insertions(+), 21 deletions(-) What changed from v1? Always put that below the --- line. v3 please? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel