From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF2BEC43603 for ; Fri, 13 Dec 2019 23:39:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 862192073D for ; Fri, 13 Dec 2019 23:39:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eqprNWgh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 862192073D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pBv+O2hpM+p7Tkh3E9FjZ2+FYod46NAhhVVAr381Gck=; b=eqprNWgh1ZlUF+ F63nbTg1Vwz54ZiT7bd0f2N4iOVwkiHX2n9Zqh7CHvYObZkmTO7APGlyewt0iGBf3VQ6ra6Y3E4YE c/xy+jHwlieQCdWCegkQtlOvY+otRVkWjPYuL9oJJ/JaubS1X2bvWElKxZzKmn+lzOXBMw7xlCEUT 7h5PU8tGfgbeRsO7Mpl+69ICm/Ogl+/oQ1seXWIotLGAm4Xc3IEwZeS7d4inYXvZfIskQzCAxzO0f 0AaO3c5lgGYTEtHqARQ8fkgmxHNL4V/OF9T9r3AXeL2T8dze2RgFF85J3w3N9PXtUumYLng/gWUp5 fw+dp5gpyfMg2HE+XnCg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifuWh-0006O4-OR; Fri, 13 Dec 2019 23:39:15 +0000 Received: from mail-ot1-f65.google.com ([209.85.210.65]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ifuWf-0006NX-A4; Fri, 13 Dec 2019 23:39:14 +0000 Received: by mail-ot1-f65.google.com with SMTP id x3so1028385oto.11; Fri, 13 Dec 2019 15:39:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=mq1TYwps803B5nZUOXXBPiLhiWAqlOlO3F5u2J7/OXo=; b=lIZA8CDSMWrBkJPQWKgSHsdzBOrZJPKPCifHIcG7Zch5hLJUS8Ud+/JxgKnKpqUr6c 4gbQyWgRR6XRDoigStlzy940UUt6xQd4O8k0DLDF0vmdu2OwR82nRd0UFzkMztblxfmu O1890/N7Ilcx3xoxNA9lEBS/tHA9ZGZVfqDyB9QSIvb2tGQ5CQOZMntZQN8v408/8J18 gyi2nXjX2th1AUVSYyq1fioqyCCgoerTXvoZ5H4pl8f4Vftm/BX9eH8G8q4CvlS+UuaM ojAokVn76LbqwqscV5ftimBuaWbdGJRtW9LU20pR/H9VqDb2WDA3Zigvru8c2AHdKmat skPA== X-Gm-Message-State: APjAAAWj4yhY57PLcjzp4GMtCdTWHfUaX+0wOC0jkBUlkIqvvp/vmFT0 wf/snvCIiS52wC/ZQ/pf4UjW12o= X-Google-Smtp-Source: APXvYqwsTPlVNmmuWh/jy0FcY+/JGCCiTNVGnBx0NSZDWLBN/Q5tOga0z2HBbu+kN45Zxu/2wQ8g+Q== X-Received: by 2002:a9d:590b:: with SMTP id t11mr8684121oth.161.1576280352011; Fri, 13 Dec 2019 15:39:12 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id v14sm3853828oto.16.2019.12.13.15.39.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2019 15:39:11 -0800 (PST) Date: Fri, 13 Dec 2019 17:39:10 -0600 From: Rob Herring To: Adrian Ratiu Subject: Re: [PATCH v4 4/4] dt-bindings: display: add i.MX6 MIPI DSI host controller doc Message-ID: <20191213233910.GA29037@bogus> References: <20191202193359.703709-1-adrian.ratiu@collabora.com> <20191202193359.703709-5-adrian.ratiu@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202193359.703709-5-adrian.ratiu@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191213_153913_359577_30DBF978 X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Neil Armstrong , Martyn Welch , Sjoerd Simons , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-imx@nxp.com, kernel@collabora.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 02, 2019 at 09:33:59PM +0200, Adrian Ratiu wrote: > This provides an example DT binding for the MIPI DSI host controller > present on the i.MX6 SoC based on Synopsis DesignWare v1.01 IP. > > Cc: Rob Herring > Cc: Neil Armstrong > Signed-off-by: Sjoerd Simons > Signed-off-by: Martyn Welch > Signed-off-by: Adrian Ratiu > --- > .../display/imx/fsl,mipi-dsi-imx6.yaml | 136 ++++++++++++++++++ > 1 file changed, 136 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml Run 'make dt_binding_check' and fix the errors. See Documentation/devicetree/writing-schema.rst. > > diff --git a/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > new file mode 100644 > index 000000000000..8c9603c28240 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/imx/fsl,mipi-dsi-imx6.yaml > @@ -0,0 +1,136 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/fsl,mipi-dsi-imx6.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX6 DW MIPI DSI Host Controller > + > +description: > + The DSI host controller is a Synopsys DesignWare MIPI DSI v1.01 IP with a companion PHY IP. > + > + These DT bindings follow the Synopsys DW MIPI DSI bindings defined in > + Documentation/devicetree/bindings/display/bridge/dw_mipi_dsi.txt with > + the following device-specific properties. > + > +properties: > + compatible: > + const: [ "fsl,imx6q-mipi-dsi", "snps,dw-mipi-dsi" ] Not valid json-schema. You want 'items' with 2 'const' entries. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Module Clock > + - description: DSI bus clock > + minItems: 2 > + maxItems: 2 Don't need these. The min/max is implied by length of 'items'. > + > + clock-names: > + items: > + - const: pclk > + - const: ref > + minItems: 2 > + maxItems: 2 > + > + fsl,gpr: > + description: Phandle to the iomuxc-gpr region containing the multiplexer control register. > + const: *gpr Not a const. Should be a phandle type. > + > + ports: > + type: object > + description: > + A node containing DSI input & output port nodes with endpoint > + definitions as documented in > + Documentation/devicetree/bindings/media/video-interfaces.txt > + Documentation/devicetree/bindings/graph.txt > + properties: > + port@0: > + type: object > + description: > + DSI input port node, connected to the ltdc rgb output port. > + > + port@1: > + type: object > + description: > + DSI output port node, connected to a panel or a bridge input port" > + > +patternProperties: > + "^(panel|panel-dsi)@[0-9]$": DSI virtual channels are 0-3 only. Do you really need both node names? > + type: object > + description: > + A node containing the panel or bridge description as documented in > + Documentation/devicetree/bindings/display/mipi-dsi-bus.txt > + properties: > + port: > + type: object > + description: > + Panel or bridge port node, connected to the DSI output port (port@1) > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > +required: > + - "#address-cells" > + - "#size-cells" > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + dsi: dsi@21e0000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,imx6q-mipi-dsi", "snps,dw-mipi-dsi"; > + reg = <0x021e0000 0x4000>; > + interrupts = <0 102 IRQ_TYPE_LEVEL_HIGH>; > + fsl,gpr = <&gpr>; > + clocks = <&clks IMX6QDL_CLK_MIPI_CORE_CFG>, > + <&clks IMX6QDL_CLK_MIPI_IPG>; > + clock-names = "ref", "pclk"; > + > + ports { > + port@0 { > + reg = <0>; > + dsi_in: endpoint { > + remote-endpoint = <<dc_ep1_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + dsi_out: endpoint { > + remote-endpoint = <&panel_in>; > + }; > + }; > + }; > + > + panel@0 { > + compatible = "sharp,ls032b3sx01"; > + reg = <0>; > + reset-gpios = <&gpio6 8 GPIO_ACTIVE_LOW>; > + > + ports { > + port@0 { > + panel_in: endpoint { > + remote-endpoint = <&dsi_out>; > + }; > + }; > + }; > + }; > + }; > + > +... > -- > 2.24.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel