From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCA7C43603 for ; Mon, 16 Dec 2019 11:21:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FE9B206CB for ; Mon, 16 Dec 2019 11:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GJWkaK/3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="UGMeVmTn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1FE9B206CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=61bSezqS8gUrPMP7B1DAytJcMPIodxbjyWtbdZChj9o=; b=GJWkaK/3wL7PvQOhRm4x0sXbq nYQmMK74nXJMOKl5ZZ3oDwxs/locfPvlujLd+1S/7Yu/uxAySqI3yA0IyIAhwGfITLJPZBmJmxIpN 9ltUTLMdAhA57Iq/+DDsCyZzfKdjz8kbj207QhLI8+j9hdJXx+C95X3X4aUDagq2mwcQBky2IzuFW NMFsvQejzUi1EL8+R35I6mJ6GH2968FhRjC6hw96bqJS29MEozL2pcEqJkhtTy3be8rowV/yJtmXH ioN0lPhuUdh3kX1Outlt4M/h4NjN/UsHWrXfXKTbNYbD00ugohPrv2oBHSjSM+idmK/y6dF/3wPCq WZY4z+Z8g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoQq-0005oR-D6; Mon, 16 Dec 2019 11:20:56 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igoQh-0005hA-Hz for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 11:20:49 +0000 Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 77993206CB; Mon, 16 Dec 2019 11:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576495247; bh=Mpc6KplCorpdPPjd389Z2K1v+WF0Ie2Wk28APYU3EIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UGMeVmTnoijpaXf0URFSEnCAv2QMv1w4vRp1RBYhvOjr4CWEskkLNUgDf2fd+/91T u9eHV45b6wdXZsbDBv6MufHf+l5akQjQKX51yICGrGeVg8jgDQZilSbp6BAom+IqcC Y7wsZm3BFQcwZ8XuLl9OoumuAFnRAITIuNShN1oI= Date: Mon, 16 Dec 2019 12:20:42 +0100 From: Maxime Ripard To: Jagan Teki Subject: Re: [PATCH v12 1/7] dt-bindings: sun6i-dsi: Document A64 MIPI-DSI controller Message-ID: <20191216112042.f4xvlgnbm4dk6wkq@gilmour.lan> References: <20191203134816.5319-1-jagan@amarulasolutions.com> <20191203134816.5319-2-jagan@amarulasolutions.com> <20191204133600.gnv6dnhk6upe7xod@gilmour.lan> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_032047_707479_809C651E X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Airlie , linux-sunxi , dri-devel , linux-kernel , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel , Icenowy Zheng Content-Type: multipart/mixed; boundary="===============2598674938377041044==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2598674938377041044== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="j7bmzwiznwnaw3ax" Content-Disposition: inline --j7bmzwiznwnaw3ax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Dec 16, 2019 at 04:37:20PM +0530, Jagan Teki wrote: > On Wed, Dec 4, 2019 at 7:06 PM Maxime Ripard wrote: > > > > On Tue, Dec 03, 2019 at 07:18:10PM +0530, Jagan Teki wrote: > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > > > to have separate compatible for A64 on the same driver. > > > > > > DSI_SCLK uses mod clock-names on dt-bindings, so the same > > > is not required for A64. > > > > > > On that note > > > - A64 require minimum of 1 clock like the bus clock > > > - A33 require minimum of 2 clocks like both bus, mod clocks > > > > > > So, update dt-bindings so-that it can document both A33, > > > A64 bindings requirements. > > > > > > Reviewed-by: Rob Herring > > > Signed-off-by: Jagan Teki > > > --- > > > Changes for v12: > > > - Use 'enum' instead of oneOf+const > > > > > > .../display/allwinner,sun6i-a31-mipi-dsi.yaml | 20 +++++++++++++++++-- > > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > index dafc0980c4fa..b91446475f35 100644 > > > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > @@ -15,7 +15,9 @@ properties: > > > "#size-cells": true > > > > > > compatible: > > > - const: allwinner,sun6i-a31-mipi-dsi > > > + enum: > > > + - allwinner,sun6i-a31-mipi-dsi > > > + - allwinner,sun50i-a64-mipi-dsi > > > > > > reg: > > > maxItems: 1 > > > @@ -24,6 +26,8 @@ properties: > > > maxItems: 1 > > > > > > clocks: > > > + minItems: 1 > > > + maxItems: 2 > > > items: > > > - description: Bus Clock > > > - description: Module Clock > > > @@ -63,13 +67,25 @@ required: > > > - reg > > > - interrupts > > > - clocks > > > - - clock-names > > > - phys > > > - phy-names > > > - resets > > > - vcc-dsi-supply > > > - port > > > > > > +allOf: > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: allwinner,sun6i-a31-mipi-dsi > > > + then: > > > + properties: > > > + clocks: > > > + minItems: 2 > > > + required: > > > + - clock-names > > > + > > > > Your else condition should check that the number of clocks items is 1 > > on the A64 > > But the minItems mentioned as 1 in clocks, which is unchanged number > by default. doesn't it sufficient? In the main schema, it's said that the clocks property can have one or two elements (to cover the A31 case that has one, and the A64 case that has 2). This is fine. Later on, you enforce that the A64 has two elements, and this is fine too. However, you never check that on the A31 you only have one clock, and you could very well have two and no one would notice. Maxime --j7bmzwiznwnaw3ax Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXfdoigAKCRDj7w1vZxhR xeS/AP9UV7Xns9t5VOhLEF+tbuQ+jcstzHVAz1d0xXveWqK7uAEAqK1mC/scTm09 qaYD48OkBiF38cUHEBrXBJdLGSE9gQI= =7xiu -----END PGP SIGNATURE----- --j7bmzwiznwnaw3ax-- --===============2598674938377041044== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2598674938377041044==--