From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2ABBC2D0C3 for ; Tue, 24 Dec 2019 18:19:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BCBC920643 for ; Tue, 24 Dec 2019 18:19:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="keSAEZtp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y91Gkvy/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BCBC920643 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UCRAzJixGapprHWg6jw2hQo1aYScLj/G5+XJMpFsjqQ=; b=keSAEZtpxupdKF UiksRs6dmPgONM/rokpshlALHGR32CDeEl1NT4a+hIFVaYUoN6ayHkHQsXDMDjQnB20F6sVIXMlgm BviqIT4Q6CoAQFq0Pzj9x195bKHw1GWwvJ9lnUiHnnWBQIkzG/YXO22kdDHtAaeS+OkGzxtlQv9oM bsZDyuIKYTSVuOCNyqAnLiiirJ4zrN+Re7LE2efi8KmWbEloHnO3gRjYB2714KKzA3Xb1Ji4t6ft7 N4d2buBhAfouLXTcjI1lIoJsffVwJFyLVo5gKfbYv/Oan/zA48rQ3YN4CWBZnDHXQS6athVSQTCZJ RLpfNCVg8zU+YiLmhT7g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijomX-00083q-4h; Tue, 24 Dec 2019 18:19:45 +0000 Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ijomS-00082b-RN for linux-arm-kernel@lists.infradead.org; Tue, 24 Dec 2019 18:19:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577211576; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Of94FGGp4Kh6qOsAiCq5CHxsSDS1gZkh3XiFNyZvlDg=; b=Y91Gkvy/V96HzY3Hj8U4dDdERfx8Nk2I8pQAva518FqQhGjgPEmFnsnqABYDSbu/t79Rhs PwkDmhUFDmfeu3ogQ+4UjFqr59g/BSgy9vy9T2iDNzCpSyNwm9/a4BfOk8XoSqtxwNTsly rWwOvAJMwyTcbsTt66AumXr8ZswDZmU= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-48-EAML3vbANA-F9UC4Q4D54A-1; Tue, 24 Dec 2019 13:19:33 -0500 Received: by mail-qv1-f70.google.com with SMTP id d7so13579297qvq.12 for ; Tue, 24 Dec 2019 10:19:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=10oE3mcJxbSPeGAikLZZiyP7ObdJq49Q5FPmOfsO/dc=; b=bn4Kg3+Sdne/ZofaRoJZQwiToQWKDyO7lwkVpzSw27xbVaMb6LTZOqHCX9+2c8HJJ4 SMYLyULpesPp5RPAEfFNX7+exmjbrs2jdaNvN1R8LJ1ILIbmFaR7EpE2SjBgk4mlno3L P4nb1WyCNLw/fWLhB95ECKFgGbHCcPYDiNM11U5yNfwo1Dn9x4Cl01V6mCiPT1Uk3ho/ lJ3luTVzfeyTSm2s6nrL2LoL2v5NTVuPFztmiu1eXBKtm9n7q9WMUH+8elrigk/XW1lF yQbZ44Us7arOuX9BRDHpf5ND/anmbb/aiSColULOJ0LtnvOYYCmS88sQeJoyMpSU16Ia of8w== X-Gm-Message-State: APjAAAWF9MLhpk+ciR90fZQHeBvFrLud2cgqi4iewHx8Dtaud8vna3cZ RbTrUSv8gwzCNcsqKc1n7vtrwIGanKsmukOqoLnxnwGfkQrKWnWV/1Ys0n9ncPtj937r128ch61 8hHg5+EACQLZjx+CTy9Eq961FJpm4k0nI9yw= X-Received: by 2002:a37:de16:: with SMTP id h22mr32000489qkj.400.1577211573533; Tue, 24 Dec 2019 10:19:33 -0800 (PST) X-Google-Smtp-Source: APXvYqyPlDOvamAwfkQQCQ/yrbEZ/IdA8BxSZxEa3M38XxUFXj9DeSRjaR1EpPHTj42i4TNzDYXwVw== X-Received: by 2002:a37:de16:: with SMTP id h22mr32000473qkj.400.1577211573294; Tue, 24 Dec 2019 10:19:33 -0800 (PST) Received: from xz-x1 ([2607:9880:19c0:3f::2]) by smtp.gmail.com with ESMTPSA id 63sm7087025qki.57.2019.12.24.10.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Dec 2019 10:19:32 -0800 (PST) Date: Tue, 24 Dec 2019 13:19:30 -0500 From: Peter Xu To: Sean Christopherson Subject: Re: [PATCH v4 16/19] KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() Message-ID: <20191224181930.GC17176@xz-x1> References: <20191217204041.10815-1-sean.j.christopherson@intel.com> <20191217204041.10815-17-sean.j.christopherson@intel.com> MIME-Version: 1.0 In-Reply-To: <20191217204041.10815-17-sean.j.christopherson@intel.com> X-MC-Unique: EAML3vbANA-F9UC4Q4D54A-1 X-Mimecast-Spam-Score: 0 Content-Disposition: inline X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191224_101940_959767_9D8A1168 X-CRM114-Status: UNSURE ( 7.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , James Hogan , Joerg Roedel , Cornelia Huck , linux-kernel@vger.kernel.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , kvm-ppc@vger.kernel.org, linux-mips@vger.kernel.org, Paul Mackerras , Christian Borntraeger , Marc Zyngier , Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2019 at 12:40:38PM -0800, Sean Christopherson wrote: > +int kvm_get_dirty_log(struct kvm *kvm, struct kvm_dirty_log *log, > + int *is_dirty, struct kvm_memory_slot **memslot) > { > struct kvm_memslots *slots; > - struct kvm_memory_slot *memslot; > int i, as_id, id; > unsigned long n; > unsigned long any = 0; > > + *memslot = NULL; > + *is_dirty = 0; > + > as_id = log->slot >> 16; > id = (u16)log->slot; > if (as_id >= KVM_ADDRESS_SPACE_NUM || id >= KVM_USER_MEM_SLOTS) > return -EINVAL; > > slots = __kvm_memslots(kvm, as_id); > - memslot = id_to_memslot(slots, id); > - if (!memslot->dirty_bitmap) > + *memslot = id_to_memslot(slots, id); > + if (!(*memslot)->dirty_bitmap) > return -ENOENT; > > - n = kvm_dirty_bitmap_bytes(memslot); > + kvm_arch_sync_dirty_log(kvm, *memslot); Should this line belong to previous patch? > + > + n = kvm_dirty_bitmap_bytes(*memslot); > > for (i = 0; !any && i < n/sizeof(long); ++i) > - any = memslot->dirty_bitmap[i]; > + any = (*memslot)->dirty_bitmap[i]; > > - if (copy_to_user(log->dirty_bitmap, memslot->dirty_bitmap, n)) > + if (copy_to_user(log->dirty_bitmap, (*memslot)->dirty_bitmap, n)) > return -EFAULT; > > if (any) > -- > 2.24.1 -- Peter Xu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel